1297000 - Modify comparison of zero TimeDuration in animation.

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

Currently, We use the TimeDuration::ToMilliseconds() in animation's implementation. [1]
However we can specify zero to TimeDuration's constructor.[2][3]
So we should replace comparison of zero TimeDuraion in animation's implementation.
e.g:
 foo.ToMilliseconds() < 0.0   to  foo < TimeDuration(0)

[1] https://dxr.mozilla.org/mozilla-central/search?q=ToMilliseconds+path%3Adom%2Fanimation%2FAnimation.cpp&redirect=true
[2] https://dxr.mozilla.org/mozilla-central/rev/f97a056ae6235de7855fd8aaa04fb1c8d183bd06/mozglue/misc/TimeStamp.h#69
[3] https://dxr.mozilla.org/mozilla-central/source/dom/animation/Animation.cpp#386

Comment 1

[Hiroyuki Ikezoe (:hiro)]

We have a constexpr variable.
http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/mozglue/misc/TimeStamp.h#l65
We should use it.

Comment 2

[fd23ef]

Attachment: bug1297000.patch

Comment 3

[fd23ef]

Attachment: bug1297000.patch

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8785541 [details] [diff] [review]
bug1297000.patch

Review of attachment 8785541 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 5

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5598abbde75

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e2503f29f53
Modify comparison of zero TimeDuration to use TimeDuration object rather than converting to milliseconds; r=birtles

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e2503f29f53