Closed
Bug 1297013
Opened 8 years ago
Closed 8 years ago
mozilla::NativeKey should log its behavior
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox51 | --- | fix-optional |
firefox52 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Whiteboard: tpi:-)
Attachments
(3 files)
Currently, we have some regression reports which are difficult to reproduce. Therefore, like IME handlers, NativeKey should log its behavior and make the reporter testable.
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3f348d373e6
Updated•8 years ago
|
Whiteboard: tpi:-
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=26fb48c58b72
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=428a185d4759
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdf0626d7898
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1dbabf4e024
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c565f868d9e
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e95482c6151
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8793146 [details] Bug 1297013 part.1 Implement ToString(const MSG&) for logging key related message with detail https://reviewboard.mozilla.org/r/79934/#review78722
Attachment #8793146 -
Flags: review?(m_kato) → review+
Comment 13•8 years ago
|
||
mozreview-review |
Comment on attachment 8793147 [details] Bug 1297013 part.2 Implement some helper methods to log constants related to event handling https://reviewboard.mozilla.org/r/79936/#review78816
Attachment #8793147 -
Flags: review?(bugs) → review+
Comment 14•8 years ago
|
||
mozreview-review |
Comment on attachment 8793148 [details] Bug 1297013 part.3 Make NativeKey log its behavior https://reviewboard.mozilla.org/r/79938/#review79318
Attachment #8793148 -
Flags: review?(m_kato) → review+
Comment 15•8 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/b1f41988e7a5 part.1 Implement ToString(const MSG&) for logging key related message with detail r=m_kato https://hg.mozilla.org/integration/autoland/rev/de82c28636a1 part.2 Implement some helper methods to log constants related to event handling r=smaug https://hg.mozilla.org/integration/autoland/rev/ce34596c89a4 part.3 Make NativeKey log its behavior r=m_kato
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b1f41988e7a5 https://hg.mozilla.org/mozilla-central/rev/de82c28636a1 https://hg.mozilla.org/mozilla-central/rev/ce34596c89a4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 17•8 years ago
|
||
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
You need to log in
before you can comment on or make changes to this bug.
Description
•