Closed Bug 1297013 Opened 3 years ago Closed 3 years ago

mozilla::NativeKey should log its behavior

Categories

(Core :: Widget: Win32, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- fix-optional
firefox52 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Whiteboard: tpi:-)

Attachments

(3 files)

Currently, we have some regression reports which are difficult to reproduce. Therefore, like IME handlers, NativeKey should log its behavior and make the reporter testable.
Status: NEW → ASSIGNED
Whiteboard: tpi:-
Comment on attachment 8793146 [details]
Bug 1297013 part.1 Implement ToString(const MSG&) for logging key related message with detail

https://reviewboard.mozilla.org/r/79934/#review78722
Attachment #8793146 - Flags: review?(m_kato) → review+
Comment on attachment 8793147 [details]
Bug 1297013 part.2 Implement some helper methods to log constants related to event handling

https://reviewboard.mozilla.org/r/79936/#review78816
Attachment #8793147 - Flags: review?(bugs) → review+
Comment on attachment 8793148 [details]
Bug 1297013 part.3 Make NativeKey log its behavior

https://reviewboard.mozilla.org/r/79938/#review79318
Attachment #8793148 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/b1f41988e7a5
part.1 Implement ToString(const MSG&) for logging key related message with detail r=m_kato
https://hg.mozilla.org/integration/autoland/rev/de82c28636a1
part.2 Implement some helper methods to log constants related to event handling r=smaug
https://hg.mozilla.org/integration/autoland/rev/ce34596c89a4
part.3 Make NativeKey log its behavior r=m_kato
https://hg.mozilla.org/mozilla-central/rev/b1f41988e7a5
https://hg.mozilla.org/mozilla-central/rev/de82c28636a1
https://hg.mozilla.org/mozilla-central/rev/ce34596c89a4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
You need to log in before you can comment on or make changes to this bug.