1297037 - [MSE] changing duration should set value to highest end time across all track

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

See https://github.com/w3c/media-source/issues/124 and the fix described in https://github.com/w3c/media-source/pull/154

currently, it sets the time to the highest end *buffered*.

need to update our implementation to be as per the new spec.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1297037: [MSE] Update Duration Change algorithm as per latest spec.

The MSE spec was recently updated to use the highest end time across tracks rather than the across the buffered ranges.

See https://github.com/w3c/media-source/issues/124 and the fix described in https://github.com/w3c/media-source/pull/154

Review commit: https://reviewboard.mozilla.org/r/74452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74452/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8785149 [details]
Bug 1297037: [MSE] Update Duration Change algorithm as per latest spec.

https://reviewboard.mozilla.org/r/74452/#review72314

r+ with nit in commit description:

::: dom/media/mediasource/MediaSource.cpp:1
(Diff revision 1)
>  /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

In commit description: 'than the across' -> 'than across'

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8785149 [details]
Bug 1297037: [MSE] Update Duration Change algorithm as per latest spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74452/diff/1-2/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8785149 [details]
Bug 1297037: [MSE] Update Duration Change algorithm as per latest spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74452/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f33fad15f7c
[MSE] Update Duration Change algorithm as per latest spec. r=gerald

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f33fad15f7c