1297058 - Don't send FEC for H.264 with NACK enabled

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Dan Minor [:dminor]]

See discussion at:

https://bugs.chromium.org/p/webrtc/issues/detail?id=5264

Comment 1

[Dan Minor [:dminor]]

Attachment: bug-1297058-fix.patch

The patch on the webrtc issue is for a code path we don't use, which embarrassingly enough I didn't notice right away.

Comment 2

[Dan Minor [:dminor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5254bd4f00b5e375f1cbe0bdbef2836e8e480bb5

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/048fa21968c6
Don't send FEC for H.264 with NACK enabled; r=jesup

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/048fa21968c6

Comment 5

[Dan Minor [:dminor]]

Unfortunately this introduced a warning which I didn't notice in my initial commit.

/home/dminor/src/firefox/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:747:26: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
if (mExternalSendCodec && codecConfig->mType == mExternalSendCodec->mType

Comment 6

[Dan Minor [:dminor]]

Warning is being fixed in 1303411.