Closed Bug 1297091 Opened 8 years ago Closed 8 years ago

Application Menu Panel Footer Looks Wrong

Categories

(Firefox :: Theme, defect)

All
Windows 10
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 51
Tracking Status
firefox51 --- verified

People

(Reporter: shorlander, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

The footer in the Application Menu Panel has regressed a bit on Nightly:

- Separators are too light
- Separators aren't properly overlapping the background (especially noticeable on hover)

The panel border also appears to be missing, but that might be a separate bug?
Seems like this is likely a regression of any/all of bug 1295929 or bug 1293967. Jaws/Dão, can you take a look?
Flags: needinfo?(jaws)
Flags: needinfo?(dao+bmo)
(In reply to Stephen Horlander [:shorlander] from comment #0)
> The panel border also appears to be missing, but that might be a separate
> bug?

bug 1296764
Assignee: nobody → dao+bmo
Blocks: 1293967
Flags: needinfo?(jaws)
Flags: needinfo?(dao+bmo)
Attached patch patchSplinter Review
Attachment #8783645 - Flags: review?(jaws)
Comment on attachment 8783645 [details] [diff] [review]
patch

Review of attachment 8783645 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this was basically my request in https://bugzilla.mozilla.org/show_bug.cgi?id=1293967#c8.
Attachment #8783645 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c23d13b55ecc
Set --panel-separator-color to hsla(210,4%,10%,.14) for the default Windows theme. r=jaws
https://hg.mozilla.org/mozilla-central/rev/c23d13b55ecc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I have reproduced this bug with Nightly 51.0a1(2016-08-22) on Windows 10, 64 bit.

The Bug's fix is now verified on Latest Nightly 51.0a1

Build ID 	20160825030226
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]
Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: