1297091 - Application Menu Panel Footer Looks Wrong

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Menu Footer - Nightly vs Release

The footer in the Application Menu Panel has regressed a bit on Nightly:

- Separators are too light
- Separators aren't properly overlapping the background (especially noticeable on hover)

The panel border also appears to be missing, but that might be a separate bug?

Comment 1

[:Gijs (he/him)]

Seems like this is likely a regression of any/all of bug 1295929 or bug 1293967. Jaws/Dão, can you take a look?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Stephen Horlander [:shorlander] from comment #0)
> The panel border also appears to be missing, but that might be a separate
> bug?

bug 1296764

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8783645 [details] [diff] [review]
patch

Review of attachment 8783645 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this was basically my request in https://bugzilla.mozilla.org/show_bug.cgi?id=1293967#c8.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c23d13b55ecc
Set --panel-separator-color to hsla(210,4%,10%,.14) for the default Windows theme. r=jaws

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c23d13b55ecc

Comment 7

[Tanvir Rahman]

I have reproduced this bug with Nightly 51.0a1(2016-08-22) on Windows 10, 64 bit.

The Bug's fix is now verified on Latest Nightly 51.0a1

Build ID 	20160825030226
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]

Comment 8

[Dão Gottwald [:dao]]

Thanks!