1297132 - Investigate removal of globalOverlay.js / goUpdateCommand from toolbox

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Brian Grinstead [:bgrins]]

toolbox.xul loads globalOverlay.js, and then toolbox.js calls goUpdateCommand from _updateTextboxMenuItems.  The toolbox's textboxContextMenuPopup variable is used from various tools in the inspector to open a context menu programmatically on elements.

We should investigate if this whole machinery can be removed and just allow a normal context menu popup to open on the text boxes instead: https://dxr.mozilla.org/mozilla-central/search?q=textboxContextMenuPopup&redirect=true.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Brian, this has been fixed already, correct?
Honza

Comment 2

[Brian Grinstead [:bgrins]]

We have goUpdateCommand at https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/devtools/client/framework/toolbox.js#3092 / https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.xul#25-26.

Looking closer though, I actually think this is unused and can be rmeoved ever since we switched to the Menu API for textboxes: https://searchfox.org/mozilla-central/search?q=_updateTextBoxMenuItems&path=.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1297132 - [devtools] Stop loading unused globalOverlay.js in toolbox

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bafa6a8f9e76
[devtools] Stop loading unused globalOverlay.js in toolbox r=rcaliman,bgrins

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bafa6a8f9e76