Closed Bug 1297157 Opened 4 years ago Closed 4 years ago

Abstract away the visuallyselected attribute on anonymous tab nodes

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This is an implementation detail that themes should not know about. It's particularly bad that we set /both/ the selected and visuallyselected attributes, inviting the use of the wrong attribute.

This patch makes all anonymous tab node use the selected attribute. The parent tab node still has the visuallyselected attribute, which sucks but fixing this requires more invasive changes.
Attachment #8783640 - Flags: review?(mconley)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8783640 [details] [diff] [review]
patch

Review of attachment 8783640 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is better. *sigh*, I forgot that we could do renames during attribute inheritance with XBL. Sorry about that.
Attachment #8783640 - Flags: review?(mconley) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d641f368849d
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley
Depends on: 1297638
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a34b88b0a
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley
Flags: needinfo?(dao+bmo)
https://hg.mozilla.org/mozilla-central/rev/bc6a34b88b0a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.