Abstract away the visuallyselected attribute on anonymous tab nodes

RESOLVED FIXED in Firefox 51

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 51
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Posted patch patchSplinter Review
This is an implementation detail that themes should not know about. It's particularly bad that we set /both/ the selected and visuallyselected attributes, inviting the use of the wrong attribute.

This patch makes all anonymous tab node use the selected attribute. The parent tab node still has the visuallyselected attribute, which sucks but fixing this requires more invasive changes.
Attachment #8783640 - Flags: review?(mconley)
Assignee

Updated

3 years ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8783640 [details] [diff] [review]
patch

Review of attachment 8783640 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is better. *sigh*, I forgot that we could do renames during attribute inheritance with XBL. Sorry about that.
Attachment #8783640 - Flags: review?(mconley) → review+

Comment 2

3 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d641f368849d
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley
Assignee

Updated

3 years ago
Depends on: 1297638

Comment 4

3 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a34b88b0a
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley
Assignee

Updated

3 years ago
Flags: needinfo?(dao+bmo)

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc6a34b88b0a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.