1297157 - Abstract away the visuallyselected attribute on anonymous tab nodes

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Dão Gottwald [:dao]]

Attachment: patch

This is an implementation detail that themes should not know about. It's particularly bad that we set /both/ the selected and visuallyselected attributes, inviting the use of the wrong attribute.

This patch makes all anonymous tab node use the selected attribute. The parent tab node still has the visuallyselected attribute, which sucks but fixing this requires more invasive changes.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8783640 [details] [diff] [review]
patch

Review of attachment 8783640 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is better. *sigh*, I forgot that we could do renames during attribute inheritance with XBL. Sorry about that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d641f368849d
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed this out, seems to be permafailing browser_devices_get_user_media_anim.js with e10s: 

https://hg.mozilla.org/integration/mozilla-inbound/rev/291f434336c6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d641f368849dd61e10de4513f525308ebea080ac

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6a34b88b0a
Abstract away the visuallyselected attribute on anonymous tab nodes. r=mconley

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc6a34b88b0a