1297171 - "mozilla/a11y/PDocAccessible.h(19): fatal error C1083: Cannot open include file: 'mozilla/a11y/COMPtrTypes.h': No such file or directory" with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Discussed with Aaron on IRC. Patch coming up.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: don't depend on accessibility enabled/disabled status for exporting COMPtrTypes.h

This works locally. I also did a bit of comment cleanup while I was there.

The Try before/after pushes look good (sorry for the extra junk in the "after" push, forgot to rearrange the patch queue a bit before pushing to Try).
https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&fromchange=922c06733e1dad18b9f2d234487448bfbfec44ec&group_state=expanded&tochange=cfc9adbab255fcb56148bc5b1bfd04a96bc98058

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8783699 [details] [diff] [review]
don't depend on accessibility enabled/disabled status for exporting COMPtrTypes.h

Review of attachment 8783699 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c45edf68dc4c
Unconditionally export COMPtrTypes.h rather than depending on accessibility enabled/disabled status. r=aklotz

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c45edf68dc4c