1297177 - Add distribution ID to filter expression context

Status: RESOLVED FIXED

(Firefox :: Normandy Server, defect, P3)

Description

[Osmose [:osmose, :mkelly]]

Now that bug 1268369 is resolved, we can access the distribution ID of Firefox builds. This is useful for filtering on funnelcake builds. We should make it available to the filter context.

Comment 1

[Chris More [:cmore]]

Do you want a few distribution IDs to see if you can target those builds?

If so, you can try "mozilla85".

Comment 2

[Osmose [:osmose, :mkelly]]

So I've got a patch that adds this filtering (it's like one line), but I can't find funnelcake build that actually has the fix from bug 1268369. The latest funnelcake I found was 47.0.1, but I think the fix landed in 48. We won't be able to target any funnelcake pre-48.

I can move forward with the fix and test against the default distribution ID, but until we have another build with a modified distribution ID based on 48 or above, the filter will be mostly useless.

cmore: Is it possible to get a 48+ build with a different distribution ID to test this on?

Comment 3

[Matt Grimes [:Matt_G]]

This is great to hear. Let me know if you need help testing from S&I end.

Comment 4

[Chris More [:cmore]]

 
> cmore: Is it possible to get a 48+ build with a different distribution ID to
> test this on?

Download the 47.0.1 Win32 funnelcake here:

https://download.mozilla.org/?product=firefox-stub-f86&os=win&lang=en-US

Then go to the amount menu and have it update to Firefox 48.

Comment 5

[Michael Cooper [:mythmon]]

When I installed that funnelcake build, and then checked for updates, it said it was at version 47.0.1 and that no updates were available. Did I do something wrong? Is there a way to get it to update besides Help>About?

Comment 6

[Chris More [:cmore]]

(In reply to Mike Cooper [:mythmon] from comment #5)
> When I installed that funnelcake build, and then checked for updates, it
> said it was at version 47.0.1 and that no updates were available. Did I do
> something wrong? Is there a way to get it to update besides Help>About?

Hmm, we're checking our builds too and giving it 24 hours to see if it updates in the background.

Comment 7

[Michael Cooper [:mythmon]]

I have to run this builds in a VM, so keeping it running constantly is really draining on my system. Is there a more direct way of triggering an update?

Comment 8

[Chris More [:cmore]]

(In reply to Mike Cooper [:mythmon] from comment #7)
> I have to run this builds in a VM, so keeping it running constantly is
> really draining on my system. Is there a more direct way of triggering an
> update?

:mythmon: try restarting Firefox now and then go to about. I talked to releng and this is all related to the WebSense security hotfix. I hot Fx 48.0.2 now. Let me know.

Comment 9

[Michael Cooper [:mythmon]]

I was able to get this updated, and can test the change now. Thanks Chris!

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/6af675ee2fc95a1ebfdbb747858f24a768350efe
Add normandy.distribution to fliter expression context.

Fixes bug 1297177

Comment 11

[Chris More [:cmore]]

(In reply to Mike Cooper [:mythmon] from comment #9)
> I was able to get this updated, and can test the change now. Thanks Chris!

Nice!

What's your first test to see if you are able to target the distribution?

Comment 12

[Michael Cooper [:mythmon]]

In a local development version of Normandy, I created a recipe with the filter expression `normandy.distribution == "mozilla86"`, which I knew would target my particular build, and give it the console log action to test it. That test was successful locally.

This feature will go out in the next deploy of normandy, which is currently unscheduled.

Comment 13

[Chris More [:cmore]]

(In reply to Mike Cooper [:mythmon] from comment #12)
> In a local development version of Normandy, I created a recipe with the
> filter expression `normandy.distribution == "mozilla86"`, which I knew would
> target my particular build, and give it the console log action to test it.
> That test was successful locally.
> 
> This feature will go out in the next deploy of normandy, which is currently
> unscheduled.

So, after the next deploy of normandy, then what?

We need to get a few baseline surveys for our two cohorts before the end of the quarter. Does this mean that we need to wait for your test to be validated outside of your local experiment and then we can potentially do the cohort surveys?

Comment 14

[Michael Cooper [:mythmon]]

I'm confident enough in this code and our automated test coverage that we don't need to validate it outside of the existing tests. Once this is deployed it will be ready to use right away. I'll direct you to Matt Grimes as far as actually setting up the surveys.

I'll CC you on the deploy bug for the next version of Normandy. It should be ready for use next week.