1297218 - Remove duplicate declaration in TrackBuffersManager.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

https://dxr.mozilla.org/mozilla-central/source/dom/media/mediasource/TrackBuffersManager.cpp#1968
 buffered.Find(aTime); is done twice.

https://people.mozilla.org/~sledru/reports/fx-scan-build/report-TrackBuffersManager.cpp-Seek-18-1.html#EndPath

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1297218 - Remove duplicate declaration in TrackBuffersManager.cpp

Review commit: https://reviewboard.mozilla.org/r/73434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73434/

Comment 2

[Jean-Yves Avenard [:jya]]

it's not really done twice (the fuzz factor has been changed in between); however it should have exited after the first call to find if Found.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8783741 [details]
Bug 1297218 - Remove duplicate declaration in TrackBuffersManager.cpp

https://reviewboard.mozilla.org/r/73434/#review71242

it's not this one you need to remove. that change would break MSE

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8783741 [details]
Bug 1297218 - Remove duplicate declaration in TrackBuffersManager.cpp

https://reviewboard.mozilla.org/r/73434/#review71244

jya is taking over...

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Ok, when I looked at the code of Find and setFuzz, I wasn't expecting this. Sorry

Comment 6

[Jean-Yves Avenard [:jya]]

I had noticed the code mistake and fixed it as part of bug 1297036

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1297218: [MSE] Remove unnecessary call to Find().

Review commit: https://reviewboard.mozilla.org/r/74456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74456/

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8785152 [details]
Bug 1297218: [MSE] Remove unnecessary call to Find().

https://reviewboard.mozilla.org/r/74456/#review72312

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8785152 [details]
Bug 1297218: [MSE] Remove unnecessary call to Find().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74456/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fed5da5f16
[MSE] Remove unnecessary call to Find(). r=gerald

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/59fed5da5f16