1297288 - Ctrl+[, Ctrl+] in developer tools trigger page back/forward

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Geoff Lankow (:darktrojan)]

I suspect this is caused by the same thing as bug 1292081, given the similarities.

STR:
In a browser window with some browsing history, open the devtools and press Ctrl+[. The browser loads the previous page as well as the devtools switching to the previous tool. Pressing Ctrl+] loads the next page.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:ochameau, can you triage this shortcuts issue?

Comment 2

[Alexandre Poirot [:ochameau]]

I don't know about the priority to give, but I'll look into it.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

I looked at all usages of shorcuts.on in devtools/client/ and it seems to be the only one left that are missing some preventDefault call.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=141ef8df1c4b

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8784006 [details] [diff] [review]
patch v1

Review of attachment 8784006 [details] [diff] [review]:
-----------------------------------------------------------------

Great, appears to work well here!

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/dd07b7887914bf4a8b20301109f5189473bb3aaa
Bug 1297288 - Prevent all toolbox key shortcuts from triggering Firefox equivalents. r=jryans

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd07b7887914

Comment 8

[Nazir Ahmed Sabbir [:NaSb]]

I've managed this issue on this bug in Nightly 50.0a1 (2016-08-22) ; (Build ID: 20160822064441) 
from Ubuntu (16.04 Bit) by following comment 0's STR.

This Bug is now verified as fixed on Latest Firefox Aurora 51.0a2 (2016-09-21) (64-bit)

Build ID: 20160921004005
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
OS: Linux 4.4.0-36-generic ; Ubuntu 16.04.1 (64 Bit)