1297357 - nsNSSCertificateDB::AddCert() unnecessarily Base64 encodes its input

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P3)

Description

[:Cykesiopka]

nsNSSCertificateDB::AddCert() (the implementation of addCert() defined in nsIX509CertDB.idl) is supposed to "Add a cert to [the] cert DB from a binary [DER] string". Currently, AddCert() simply takes the given DER input, encodes it to Base64, then calls nsNSSCertificateDB::AddCertFromBase64() to do the remaining work.

While this works, it's not very logical since AddCertFromBase64() eventually decodes the given Base64 input back to DER.

The method should be updated to avoid this unnecessary work.

Comment 1

[Moritz Birghan [:mbirghan]]

Attachment: Bug 1297357 - Switch work from nsNSSCertificateDB::AddCertFromBase64() to nsNSSCertificateDB::AddCert(). r=keeler

Comment 2

[Dana Keeler (she/her) [:keeler]]

Moritz - this is ready to land, but it looks like the commit doesn't have the authorship information set up correctly - see https://wiki.mozilla.org/Phabricator/FAQ#Lando for more details.

Comment 3

[Moritz Birghan [:mbirghan]]

I have edited my authorship information and resubmitted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6ddac3b94da
Switch work from nsNSSCertificateDB::AddCertFromBase64() to nsNSSCertificateDB::AddCert(). r=keeler

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d6ddac3b94da