1297376 - Coverity issues in Snapshots 164888 and 164965

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Comment 1

[Franziskus Kiefer [:franziskus]]

Attachment: coverity2308.patch

a couple of missing frees and and unused value.

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8783950 [details] [diff] [review]
coverity2308.patch

Review of attachment 8783950 [details] [diff] [review]:
-----------------------------------------------------------------

::: cmd/certutil/certutil.c
@@ +213,5 @@
>          spki->algorithm.parameters.data = NULL;
>          rv = SECOID_SetAlgorithmID(arena, &spki->algorithm,
>                                     SEC_OID_PKCS1_RSA_PSS_SIGNATURE, 0);
> +        if (rv != SECSuccess) {
> +            PORT_FreeArena(arena, PR_FALSE);

I would have preferred to have this somewhere I can get context.  It's a huge inconvenience reviewing code in splinter sometimes.

Comment 3

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/2568d4d26210

Comment 4

[Franziskus Kiefer [:franziskus]]

Sometimes I don't understand coverity. First it complains about leaking those values. Now it complains about freeing them. I'll have to have another look at this.

Comment 5

[Franziskus Kiefer [:franziskus]]

Can't find those issues anymore in coverity