1297379 - Port Bug 1294650 Block Websense Endpoint by providing a dummy DLL

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1294650 might affect Seamonkey too so copy the shim 'qipcap' dll also into the Seamonkey folder during installation.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1297379-websense.patch

Comment 2

[Philip Chee]

Comment on attachment 8783958 [details] [diff] [review]
1297379-websense.patch

r=me a=me

Comment 3

[Frank-Rainer Grahl (:frg)]

push backout push comment had wrong bug # in it.
https://hg.mozilla.org/comm-central/rev/2ef0fbba50a3
https://hg.mozilla.org/comm-central/rev/3c42168bf8d3
https://hg.mozilla.org/comm-central/rev/851a48c4761b

Comment 4

[Frank-Rainer Grahl (:frg)]

Leaving open for branches. I think the original bug will get pushed to all fo them.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8783958 [details] [diff] [review]
1297379-websense.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Seamonkey might crash if Websense is installed.
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): none. Its just a dummy dll.
String changes made by this patch: none

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8783958 [details] [diff] [review]
1297379-websense.patch

[Approval Request Comment]
Has now been pushed to c-r also. See comment 5 for information.

Comment 7

[Ian Neal]

Comment on attachment 8783958 [details] [diff] [review]
1297379-websense.patch

a=me for c-r

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-aurora/rev/559856ab8275
https://hg.mozilla.org/releases/comm-beta/rev/9dcfba4592a9
https://hg.mozilla.org/releases/comm-release/rev/75e7d671fe05

not closing because original bug has been reopened for further investigation.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1297379-websense-backout.patch

[Approval Request Comment]
Regression caused by (bug #): 1294650 and 1298157
User impact if declined: Windows build fails
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none.

Comment 10

[Ian Neal]

Comment on attachment 8787743 [details] [diff] [review]
1297379-websense-backout.patch

a/r=me

Comment 11

[Frank-Rainer Grahl (:frg)]

Backout:
https://hg.mozilla.org/comm-central/rev/023e39ec99df
https://hg.mozilla.org/releases/comm-aurora/rev/9e32c6ab65f2
https://hg.mozilla.org/releases/comm-beta/rev/581f90b8814b

Will not be backed out from c-r for now because it seems it will remain in m-r.

Comment 12

[Frank-Rainer Grahl (:frg)]

I think we can close the bug for now even with bug 1294650 still open.