Closed
Bug 1297449
Opened 8 years ago
Closed 8 years ago
Event edit dialog is unusable with a long attendee list
Categories
(Calendar :: Dialogs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.7.4
People
(Reporter: dgtscqfez7, Assigned: MakeMyDay)
Details
Attachments
(2 files, 1 obsolete file)
183.35 KB,
image/png
|
Details | |
3.14 KB,
patch
|
MakeMyDay
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160610120335 Steps to reproduce: Open the edit event dialog for an event with a very long list of attendees, such as everyone in an entire department. Actual results: The dialog box tries to display all of the attendees in a non-scrollable list. The list goes way off the bottom of the screen, and as a result you can't get to the description box or the OK and Cancel buttons. Expected results: The attendee list should use a scrollbar so that it fits on the screen.
Assignee | ||
Comment 1•8 years ago
|
||
Confirming. This is an issue in the summary dialog and probably also event dialog as this is mostly shared functionality.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
This patch takes care of it.
Attachment #8788251 -
Flags: review?(richard.marti)
Comment 3•8 years ago
|
||
Comment on attachment 8788251 [details] [diff] [review] FixManyAttendeeOverflowInSummaryDialog-v1.diff Review of attachment 8788251 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Please can you change https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-summary-dialog.xul#11 to <?xml-stylesheet type="text/css" href="chrome://calendar-common/skin/dialogs/calendar-event-dialog.css"?> ? Then the rules in common calendar-event-dialog.css will work. I must have missed this line when I added the calendar-common logic. ::: calendar/base/themes/common/dialogs/calendar-event-dialog.css @@ +516,5 @@ > +#calendar-event-summary-dialog #item-description, > +#calendar-task-summary-dialog #item-description { > + min-height: 54px; > +} > + Empty line too much.
Attachment #8788251 -
Flags: review?(richard.marti) → review+
Assignee | ||
Comment 4•8 years ago
|
||
As discussed on IRC, I do not include the requested fix for the calendar-common link as this results in further regressions, which I want to avoid at this point as this patch is mainly for uplift. Therefor I added the min-height decalaration to calendar-attendees.css as an interim solution. Once the summary dialog is cleaned up for the upcoming ESR release, this needs to be moved elsewhere.
Attachment #8788251 -
Attachment is obsolete: true
Attachment #8792128 -
Flags: review+
Attachment #8792128 -
Flags: approval-calendar-esr?(philipp)
Attachment #8792128 -
Flags: approval-calendar-beta?(philipp)
Attachment #8792128 -
Flags: approval-calendar-aurora?(philipp)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7ed5fb322056a2fde371c4f1fd3b0d81b168f02e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → 5.1
Assignee | ||
Updated•8 years ago
|
Target Milestone: 5.1 → 5.3
Updated•8 years ago
|
Attachment #8792128 -
Flags: approval-calendar-esr?(philipp)
Attachment #8792128 -
Flags: approval-calendar-esr+
Attachment #8792128 -
Flags: approval-calendar-beta?(philipp)
Attachment #8792128 -
Flags: approval-calendar-beta+
Attachment #8792128 -
Flags: approval-calendar-aurora?(philipp)
Attachment #8792128 -
Flags: approval-calendar-aurora+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/767d9f98e5e3a64232b0a994b6b9f0b34494a50b https://hg.mozilla.org/releases/comm-beta/rev/8f54e69715f50f817ced01988d8b1b236956d093 https://hg.mozilla.org/releases/comm-esr45/rev/1fdbd73ee121827202944948e283321a01cbc122
Target Milestone: 5.3 → 4.7.4
You need to log in
before you can comment on or make changes to this bug.
Description
•