1297479 - Create a pref to turn off our undo UI for automigration

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[:Gijs (he/him)]

This is mostly because the funnelcake experiment likely won't want our UI, so they have an easy way to turn it off by default.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1297479 - create a pref to turn off UI to undo automatic migration for use by funnelcake builds,

Review commit: https://reviewboard.mozilla.org/r/73650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73650/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8784079 [details]
Bug 1297479 - create a pref to turn off UI to undo automatic migration for use by funnelcake builds,

https://reviewboard.mozilla.org/r/73650/#review71802

::: browser/app/profile/firefox.js:1485
(Diff revision 1)
>  
>  pref("browser.migrate.automigrate.enabled", false);
>  // 4 here means the suggestion notification will be automatically
>  // hidden the 4th day, so it will actually be shown on 3 different days.
>  pref("browser.migrate.automigrate.daysToOfferUndo", 4);
> +pref("browser.migrate.automigrate.ui.enabled", true);

Kinda seems like this should be false until we decide to enable it? (But also kinda moot with .automigrate.enabled being off.)

Comment 3

[:Gijs (he/him)]

Comment on attachment 8784079 [details]
Bug 1297479 - create a pref to turn off UI to undo automatic migration for use by funnelcake builds,

https://reviewboard.mozilla.org/r/73650/#review72002

::: browser/app/profile/firefox.js:1485
(Diff revision 1)
>  
>  pref("browser.migrate.automigrate.enabled", false);
>  // 4 here means the suggestion notification will be automatically
>  // hidden the 4th day, so it will actually be shown on 3 different days.
>  pref("browser.migrate.automigrate.daysToOfferUndo", 4);
> +pref("browser.migrate.automigrate.ui.enabled", true);

My thinking was that we don't normally want to be in a situation where we enable automigration and disable the UI (except in this funnelcake if that's what cmore's team wants) and so this seemed like the "safer" default. But yes, it's kind of moot at the minute anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/964df423d84e
create a pref to turn off UI to undo automatic migration for use by funnelcake builds, r=Dolske

Comment 5

[:Gijs (he/him)]

This was uplifted as part of bug 1289231.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/964df423d84e