1297504 - Don't reset document.currentScript to old value until current script finishes running

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Decky Coss (:deckycoss)]

according to the spec, currentScript should point to the script that is currently being executed, until that execution stops. (https://html.spec.whatwg.org/multipage/scripting.html#execute-the-script-block)

however, the failing "script-window-error" test shows that currentScript is reset to the old value early, before the current script's exceptions are reported: http://w3c-test.org/html/dom/documents/dom-tree-accessors/Document.currentScript.sub.html

this can possibly be fixed by moving the AutoEntryScript instance to the same scope as scriptUpdater: https://hg.mozilla.org/mozilla-central/file/052656fc513c/dom/base/nsScriptLoader.cpp#l1998

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Decky, is this something we plan to do in the next few months (P2) or a nice-to-have (P3, backlog)?

Comment 2

[Decky Coss (:deckycoss)]

i would prefer to defer that question to ehsan.

Comment 3

[(no longer active)]

Decky's internship is finished, so I think this will be a nice to have bug on the back burner until someone decides to pick it up!

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks Decky and Ehsan for the input.

Comment 5

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.