1297528 - remove some useless declarations in WebGLExtensionTextureFloat.cpp

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Most of the assignation of swizzle are useless.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1297528 - Most of the assignations of 'swizzle' are useless.

Review commit: https://reviewboard.mozilla.org/r/73676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73676/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8784151 [details]
Bug 1297528 - Most of the assignations of 'swizzle' are useless.

https://reviewboard.mozilla.org/r/73676/#review71570

::: dom/canvas/WebGLExtensionTextureFloat.cpp
(Diff revision 1)
>      pi = {LOCAL_GL_LUMINANCE, LOCAL_GL_FLOAT};
>      dui = {pi.format, pi.format, pi.type};
> -    swizzle = nullptr;
>      if (needsSwizzle) {
>          dui = {LOCAL_GL_R32F, LOCAL_GL_RED, LOCAL_GL_FLOAT};
> -        swizzle = webgl::FormatUsageInfo::kLuminanceSwizzleRGBA;

The heck? No way!

Comment 3

[Kelsey Gilbert [:jgilbert]]

These are not actually unused.
The nullptr ones are likely redundant to the default value, but are useful for explicit readability.
The others should be being used, just maybe not on your OS/driver.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8784151 [details]
Bug 1297528 - Most of the assignations of 'swizzle' are useless.

https://reviewboard.mozilla.org/r/73676/#review71570

> The heck? No way!

Seems that it is a false positive of our tools. Sorry