129763 - edit this page and delete Personals section causes stray bullet

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[sujay]

using 3/8 build

1) launch netscape
2) jump to above page
3) File | Edit Page
4) scroll down and delete all the bullets under Personal, drag mouse from last
bullet all the way upward thru "Personals"
5) delete

now notice under 

Group Issues you have

* None
	o  <--  how did this bullet get there? it was not there
originally 		                before step 5) above

Comment 1

[sujay]

changing summary

Comment 2

[Joe Francis]

Sadly, the word "Personals" does not occur anywhere in the document
http://jazz/users/sujay/publish/marsqa.html.  Did you mean to link a different
document?

Marking invalid so that Sujay will see this.

Comment 3

[sujay]

Joe, I fixed the URL...you shoud be able to replicate this problem now...

REOPEN.

Comment 4

[Kevin McCluskey (gone)]

Clearing EDITORBASE+ and nsbeta1 for re-consideration since the fix has been
determined to be both difficult and risky.

Comment 5

[Syd Logan]

Joe, what is the risk, how long will this take to fix? This really looks like 
the kind of thing we want for EDITORBASE.

Comment 6

[Kevin McCluskey (gone)]

editorbase triage: Marking EDITORBASE+, nsbeta1+, [adt1]. This is a very common
operation.

Comment 7

[Kevin McCluskey (gone)]

Simple test case:

Create a new document.
Add a list item
Add another list item and indent it so you have the following

 *item1
    *item2

Select item2 and item1 by dragging from item2 over item1.

Hit the delete key. You will see the following

 *
    *

Only the item content seems to have been selected.
If you do a select all it works as expected.

Selection issue?

Joe: Is this a selection issue? Should this be reassigned to mjudge?

Comment 8

[Joe Francis]

Kevin: the test case you mention in comment #7 is a known issue.  There may be a 
bug agisnt me for that already.  

Comment 9

[scottputterman]

marking [adt1 rtm].  This is not a beta stop ship bug.  Let's get this in for rtm.

Comment 10

[Joe Francis]

I think I know what has to happen here but it is not something we would want on
the branch without a lot of testing.  trying to finish up a patch soon so folks
can try it out.

Comment 11

[sujay]

If this is something we don't want on the branch then I think
we should minus this unless Joe can do a lot of unit testing
on this fix.

Comment 12

[Joe Francis]

Attachment: patch to nsHTMLEditRules.{h,cpp}

I've been tweaking this for a long time now, and I think it is ready for more
eyes.  This changes the behavior of deletion when you have a non-collapsed
selection.  We should get some feedback on if this is good or bad.

Comment 13

[Jaime Rodriguez, Jr.]

Lowering impact to [ADT2 RTM], per ADT triage.

Comment 14

[Joe Francis]

The trunk is the wave of the future!

Comment 15

[Kevin McCluskey (gone)]

nsbeta1-. The fix is too risky for the 1.0 branch.

Comment 16

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 17

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

FQDN url, thanks...

Comment 18

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 83717 [details] [diff] [review]
patch to nsHTMLEditRules.{h,cpp}

r=glazman

Comment 19

[kinmoz]

Comment on attachment 83717 [details] [diff] [review]
patch to nsHTMLEditRules.{h,cpp}

sr=[e-mail]

Comment 20

[Joe Francis]

fix landed on trunk

Comment 21

[Joe Francis]

fix does not seem to working on trunk.  investigating...

Comment 22

[Joe Francis]

ok, really fixed now.

Comment 23

[sujay]

verified in 9/5 trunk build.