1297647 - Misleading indentation in nsMaiHyperLink.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nicolas Silva [:nical]]

Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/atk/nsMaiHyperlink.cpp#191

This if block needs to be braced. It is most likely a bug.

Comment 1

[:Gijs (he/him)]

I assume Alex knows more about this.

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Nicolas Silva [:nical] from comment #0)
> Here:
> http://searchfox.org/mozilla-central/rev/
> b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/atk/nsMaiHyperlink.
> cpp#191
> 
> This if block needs to be braced. It is most likely a bug.

its correct, just baddly indented.  I'm not sure if this is from me sucking at indentation or the time when it was using 4 space indents, but either way it just needs some whitespace fixup.
(In reply to :Gijs Kruitbosch from comment #1)
> I assume Alex knows more about this.

actually atk/ is me.

Comment 3

[:Cykesiopka]

Attachment: Bug 1297647 - Fix misleading indentation in nsMaiHyperLink.cpp.

Review commit: https://reviewboard.mozilla.org/r/75628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75628/

Comment 4

[:Cykesiopka]

nical: Apologies if you already had a patch for this. This is blocking me from using GCC6 and --enable-warnings-as-errors, so I wanted to fix it sooner rather than later.

Comment 5

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0699c83e4ba

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/448e4062cba4
Fix misleading indentation in nsMaiHyperLink.cpp. r=tbsaunde

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/448e4062cba4