1297649 - Misleading indentation in UtilInterface.cpp and nsMaiInterfaceDocument.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nicolas Silva [:nical]]

Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/atk/UtilInterface.cpp#257

This one looks like it is not actually a bug. The code after the return 0; should have one less indentation level, and the if should be braced. This is important because almost all other misleading indentation warnings I have come across so far are actual bugs.

Comment 1

[Nicolas Silva [:nical]]

Same thing in nsMaiInterfaceDocument.cpp: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/atk/nsMaiInterfaceDocument.cpp#64

Comment 2

[Trevor Saunders (:tbsaunde)]

(In reply to Nicolas Silva [:nical] from comment #1)
> Same thing in nsMaiInterfaceDocument.cpp:
> http://searchfox.org/mozilla-central/rev/
> b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/atk/
> nsMaiInterfaceDocument.cpp#64

correct for both, the indentation on the first is also a wierd mixture of 2 and 4 space, it'd be nice to fix that while there fixing whitespace.

Comment 3

[:Cykesiopka]

Attachment: Bug 1297649 - Fix misleading indentation in UtilInterface.cpp and nsMaiInterfaceDocument.cpp.

Review commit: https://reviewboard.mozilla.org/r/75624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75624/

Comment 4

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0699c83e4ba

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ca39559f08e
Fix misleading indentation in UtilInterface.cpp and nsMaiInterfaceDocument.cpp. r=tbsaunde

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ca39559f08e