Revert jit-test workaround for Windows/NSPR threading issues

ASSIGNED
Assigned to

Status

()

defect
P3
normal
ASSIGNED
3 years ago
6 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

({leave-open, triage-deferred})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
The patch for bug 970063 made us ignore test timeouts on some Windows versions due to a Windows bug we hit with NSPR threads (see bug 970063 comment 7).
Assignee

Comment 1

3 years ago
Posted patch PatchSplinter Review
Attachment #8784305 - Flags: review?(nfitzgerald)
Attachment #8784305 - Flags: review?(nfitzgerald) → review+
Just wondering, is this ready for landing?
Flags: needinfo?(jdemooij)

Comment 3

3 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c9882472df
Remove jit-test workaround for Windows/NSPR threading issues. r=fitzgen
Assignee

Comment 4

3 years ago
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #2)
> Just wondering, is this ready for landing?

Sorry for the delay. I have a bit of a backlog atm, will push more stuff this week.
Flags: needinfo?(jdemooij)
Assignee

Comment 5

3 years ago
Bah, I backed this out because it makes Windows CGC jobs timeout.

We just need to add more tests to the slow-tests-with-CGC file I guess.
Assignee

Updated

3 years ago
Keywords: leave-open

Comment 6

3 years ago
Backout by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d68d4884890
Backed out changeset c1c9882472df for cgc timeouts.
Keywords: triage-deferred
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?
Flags: needinfo?(jdemooij)
Assignee

Comment 8

6 months ago
(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7)
> The leave-open keyword is there and there is no activity for 6 months.
> :jandem, maybe it's time to close this bug?

Nope, we still want to fix this.
Flags: needinfo?(jdemooij)
You need to log in before you can comment on or make changes to this bug.