1297652 - Revert jit-test workaround for Windows/NSPR threading issues

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jan de Mooij [:jandem]]

The patch for bug 970063 made us ignore test timeouts on some Windows versions due to a Windows bug we hit with NSPR threads (see bug 970063 comment 7).

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Just wondering, is this ready for landing?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c9882472df
Remove jit-test workaround for Windows/NSPR threading issues. r=fitzgen

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #2)
> Just wondering, is this ready for landing?

Sorry for the delay. I have a bit of a backlog atm, will push more stuff this week.

Comment 5

[Jan de Mooij [:jandem]]

Bah, I backed this out because it makes Windows CGC jobs timeout.

We just need to add more tests to the slow-tests-with-CGC file I guess.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d68d4884890
Backed out changeset c1c9882472df for cgc timeouts.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 8

[Jan de Mooij [:jandem]]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7)
> The leave-open keyword is there and there is no activity for 6 months.
> :jandem, maybe it's time to close this bug?

Nope, we still want to fix this.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 15

[Jan de Mooij [:jandem]]

Attachment: Bug 1297652 part 1 - Revert jit-test workaround for Windows/NSPR threading issues. r?iain!

When this last landed (5 years ago), it was backed out because some slow tests caused
timeouts. The SM Windows CI builds now run on Windows Server 2012, which has kernel
version 6.2, so shouldn't be affected by this workaround for versions 6.0 and 6.1.

Comment 16

[Jan de Mooij [:jandem]]

Attachment: Bug 1297652 part 2 - Fix auto-formatted code to be more readable. r?iain!

Depends on D133630

Comment 17

[Jan de Mooij [:jandem]]

Attachment: Bug 1297652 part 3 - Remove another Windows-specific workaround. r?iain!

This bug might have been related to the other (NSPR) issue, or maybe it only affected
Windows 7 to begin with. We can easily add this back if it still happens.

Depends on D133647

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a8a683341db
part 1 - Revert jit-test workaround for Windows/NSPR threading issues. r=iain
https://hg.mozilla.org/integration/autoland/rev/6e95dc63f3d2
part 2 - Fix auto-formatted code to be more readable. r=iain

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7285a00652cd
part 3 - Remove another Windows-specific workaround. r=iain

Comment 20

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a8a683341db
https://hg.mozilla.org/mozilla-central/rev/6e95dc63f3d2
https://hg.mozilla.org/mozilla-central/rev/7285a00652cd