If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Misleading indentation in accessible/base/Logging.cpp

RESOLVED FIXED in Firefox 51

Status

()

Core
Disability Access APIs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: nical, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/base/Logging.cpp#117

Introduced by this commit:

http://searchfox.org/mozilla-central/diff/158a12ab7262e092896e8446d60e36929cfacaa1/accessible/src/base/Logging.cpp#111

Looking at the hg history, it isn't clear to me that "[failed]" should be printed at all, it should probably be removed. I don't know this code so I am not sure, though.
(Reporter)

Updated

a year ago
No longer blocks: 1297639

Comment 1

a year ago
[failed] should be removed
(Reporter)

Updated

a year ago
Blocks: 1297639

Updated

a year ago
Depends on: 939049
(Assignee)

Comment 2

a year ago
Created attachment 8784354 [details] [diff] [review]
remove printf that was useless after bug 939049

ugh, silly regression to put in :(
Attachment #8784354 - Flags: review?(bugs)

Updated

a year ago
Attachment #8784354 - Flags: review?(bugs) → review+

Comment 3

a year ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b78eab191453
remove printf that was useless after bug 939049 r=smaug

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b78eab191453
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.