Closed Bug 1297661 Opened 3 years ago Closed 3 years ago

Misleading indentation in accessible/base/Logging.cpp

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: nical, Assigned: tbsaunde)

References

Details

Attachments

(1 file)

Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/accessible/base/Logging.cpp#117

Introduced by this commit:

http://searchfox.org/mozilla-central/diff/158a12ab7262e092896e8446d60e36929cfacaa1/accessible/src/base/Logging.cpp#111

Looking at the hg history, it isn't clear to me that "[failed]" should be printed at all, it should probably be removed. I don't know this code so I am not sure, though.
No longer blocks: 1297639
[failed] should be removed
Blocks: 1297639
Depends on: 939049
ugh, silly regression to put in :(
Attachment #8784354 - Flags: review?(bugs)
Attachment #8784354 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/b78eab191453
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.