1297662 - Remove unused file gf2_8.c & gf2_8.h

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nicolas Silva [:nical]]

gcc -Wmisleading-indentation warning here (and the following lines): http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/netwerk/srtp/src/crypto/math/gf2_8.c#57

Not sure if the code in gf2_8.c is actually correct, but a lot of the occurrences of the warning are bugs, so we need to make gecko build without this warning.

Comment 1

[Honza Bambas (:mayhemer)]

Nicolas, feel free to find a different owner.

Comment 2

[:Cykesiopka]

FWIW, this file appears to have been removed upstream:
https://github.com/cisco/libsrtp/commit/8aa936e9b528efb09cead64ea49f900cda547d7f
... with the misleading indentation unfixed.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

Review commit: https://reviewboard.mozilla.org/r/81080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81080/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d52a60048a7

Comment 5

[Sylvestre Ledru [:Sylvestre]]

The code coverage of this file is 0%. However, I don't expect my try to work.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Actually, it worked. I polished the patch a bit more.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8794783 [details]
Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81080/diff/1-2/

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8794783 [details]
Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

https://reviewboard.mozilla.org/r/81080/#review79952

We can remove it though note that we're on an older branch of srtp (1.x) not the current 2.x branch.  In general we try to avoid landing build/warning fixes and "cleanup" on upstream code, since that makes future imports more painful.  If possible it's better to land changes in the moz.build/etc files to disable specific warnings.  However, we can take this.

I verified this is the exact code that was in the (removed) .h file.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8794783 [details]
Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

https://reviewboard.mozilla.org/r/81080/#review79952

I agree with you. As it is dead code being compiled... :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8009d19e29e0
Remove gf2_8.c & gf2_8.h as they are unused. r=jesup

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8009d19e29e0