Remove unused file gf2_8.c & gf2_8.h

RESOLVED FIXED in Firefox 52

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: nical, Assigned: sylvestre)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [necko-active])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
gcc -Wmisleading-indentation warning here (and the following lines): http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/netwerk/srtp/src/crypto/math/gf2_8.c#57

Not sure if the code in gf2_8.c is actually correct, but a lot of the occurrences of the warning are bugs, so we need to make gecko build without this warning.
(Reporter)

Updated

a year ago
No longer blocks: 1297639
(Reporter)

Updated

a year ago
Blocks: 1297639
Nicolas, feel free to find a different owner.
Assignee: nobody → nical.bugzilla
Whiteboard: [necko-active]

Comment 2

a year ago
FWIW, this file appears to have been removed upstream:
https://github.com/cisco/libsrtp/commit/8aa936e9b528efb09cead64ea49f900cda547d7f
... with the misleading indentation unfixed.
Comment hidden (mozreview-request)
(Assignee)

Comment 4

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d52a60048a7
(Assignee)

Comment 5

a year ago
The code coverage of this file is 0%. However, I don't expect my try to work.
(Assignee)

Comment 6

a year ago
Actually, it worked. I polished the patch a bit more.
Assignee: nical.bugzilla → sledru
Summary: Misleading indentation in gf2_8.c → Remove unused file gf2_8.c & gf2_8.h
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8794783 - Flags: review?(rjesup)

Comment 8

a year ago
mozreview-review
Comment on attachment 8794783 [details]
Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

https://reviewboard.mozilla.org/r/81080/#review79952

We can remove it though note that we're on an older branch of srtp (1.x) not the current 2.x branch.  In general we try to avoid landing build/warning fixes and "cleanup" on upstream code, since that makes future imports more painful.  If possible it's better to land changes in the moz.build/etc files to disable specific warnings.  However, we can take this.

I verified this is the exact code that was in the (removed) .h file.
Attachment #8794783 - Flags: review?(rjesup) → review+
(Assignee)

Comment 9

a year ago
mozreview-review-reply
Comment on attachment 8794783 [details]
Bug 1297662 - Remove gf2_8.c & gf2_8.h as they are unused.

https://reviewboard.mozilla.org/r/81080/#review79952

I agree with you. As it is dead code being compiled... :)

Comment 10

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8009d19e29e0
Remove gf2_8.c & gf2_8.h as they are unused. r=jesup

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8009d19e29e0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.