Closed Bug 1297828 Opened 3 years ago Closed 3 years ago

Make gfxCriticalError work in the GPU process

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dvander, Assigned: gw280)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

gfxCriticalError assumes !XRE_IsParentProcess == XRE_IsContentProcess(), which is no longer true. We'll have to update it and route messages over PGPU, and expose a singleton for GPUParent. Probably we'd want different decoration on the log messages too.

Entrypoint is here maybe? http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/gfx/thebes/gfxPlatform.cpp#335
Whiteboard: [gfx-noted]
Assignee: nobody → gwright
Attachment #8797300 - Flags: review?(dvander) → review+
Comment on attachment 8797301 [details] [diff] [review]
0002-Bug-1297828-Ensure-gfx-logging-works-in-the-GPU-proc.patch

Review of attachment 8797301 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatform.cpp
@@ +356,5 @@
> +      if (XRE_IsContentProcess()) {
> +        dom::ContentChild* cc = dom::ContentChild::GetSingleton();
> +        Unused << cc->SendGraphicsError(stringToSend);
> +      } else if (XRE_IsGPUProcess()) {
> +              printf("GPU PROC!\n\n");

nit: remove this printf before landing

::: gfx/thebes/gfxPlatform.h
@@ +181,4 @@
>       */
>      static void InitNullMetadata();
>  
> +    static void InitFactory();

nit: Please name this something more descriptive, like "InitMoz2DLogging".
Attachment #8797301 - Flags: review?(dvander) → review+
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41be8df28766
Add GraphicsError to PGPU r=dvander
https://hg.mozilla.org/integration/mozilla-inbound/rev/8aefe3650d8d
Ensure gfx logging works in the GPU process r=dvander
https://hg.mozilla.org/mozilla-central/rev/41be8df28766
https://hg.mozilla.org/mozilla-central/rev/8aefe3650d8d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.