1297828 - Make gfxCriticalError work in the GPU process

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

gfxCriticalError assumes !XRE_IsParentProcess == XRE_IsContentProcess(), which is no longer true. We'll have to update it and route messages over PGPU, and expose a singleton for GPUParent. Probably we'd want different decoration on the log messages too.

Entrypoint is here maybe? http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/gfx/thebes/gfxPlatform.cpp#335

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1297828-Add-GraphicsError-to-PGPU.patch

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: 0002-Bug-1297828-Ensure-gfx-logging-works-in-the-GPU-proc.patch

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8797301 [details] [diff] [review]
0002-Bug-1297828-Ensure-gfx-logging-works-in-the-GPU-proc.patch

Review of attachment 8797301 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatform.cpp
@@ +356,5 @@
> +      if (XRE_IsContentProcess()) {
> +        dom::ContentChild* cc = dom::ContentChild::GetSingleton();
> +        Unused << cc->SendGraphicsError(stringToSend);
> +      } else if (XRE_IsGPUProcess()) {
> +              printf("GPU PROC!\n\n");

nit: remove this printf before landing

::: gfx/thebes/gfxPlatform.h
@@ +181,4 @@
>       */
>      static void InitNullMetadata();
>  
> +    static void InitFactory();

nit: Please name this something more descriptive, like "InitMoz2DLogging".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41be8df28766
Add GraphicsError to PGPU r=dvander
https://hg.mozilla.org/integration/mozilla-inbound/rev/8aefe3650d8d
Ensure gfx logging works in the GPU process r=dvander

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41be8df28766
https://hg.mozilla.org/mozilla-central/rev/8aefe3650d8d