Closed
Bug 1297829
Opened 8 years ago
Closed 8 years ago
Use push inspector URL in release emails
Categories
(Release Engineering :: Release Automation, defect)
Release Engineering
Release Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: csheehan)
References
Details
Attachments
(2 files, 1 obsolete file)
46 bytes,
text/x-github-pull-request
|
rail
:
review+
rail
:
checked-in+
|
Details | Review |
49 bytes,
text/x-github-pull-request
|
rail
:
review+
rail
:
checked-in+
|
Details | Review |
because https://tools.taskcluster.net/push-inspector is cool!
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → csheehan
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8786070 -
Flags: review?(rail)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8786070 [details] [review]
Adds push-inspector url for task group to SES emails.
Oooop, sorry, I wasn't clear enough. The release emails are good, they point you to a particular task. What I meant is the initial email sent to release-drivers, https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/__init__.py#105
BTW, once you touched pulse-notify, can you simplify the email template and remove the redundant CSS styles? ;)
Attachment #8786070 -
Flags: review?(rail) → review-
Comment 3•8 years ago
|
||
I think it's worth switching to push-inspector in releasewarrior too (e.g. task graph from https://github.com/mozilla/releasewarrior/blob/master/releases/firefox-beta-49.0b7.md)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Mihai Tabara [:mtabara] from comment #3)
> I think it's worth switching to push-inspector in releasewarrior too (e.g.
> task graph from
> https://github.com/mozilla/releasewarrior/blob/master/releases/firefox-beta-
> 49.0b7.md)
Good idea, but the PR link is 404! :P
Assignee | ||
Comment 5•8 years ago
|
||
As far as I can tell the push-inspector uses the same id as the task-graph-inspector, so changing to the new URL should be enough.
Attachment #8786070 -
Attachment is obsolete: true
Attachment #8787296 -
Flags: review?(rail)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8787296 [details] [review]
Changes task-graph-inspector link to push-inspector.
https://hg.mozilla.org/build/tools/rev/fc03b8cd3062
Attachment #8787296 -
Flags: review?(rail)
Attachment #8787296 -
Flags: review+
Attachment #8787296 -
Flags: checked-in+
Comment 7•8 years ago
|
||
The email for Build of Firefox-49.0b9-build1 has successfully changed \o/
--
A new build has been submitted through ship-it:
Commit: https://hg.mozilla.org/releases/mozilla-beta/rev/e3cc699ccef2abb7075c39e7b9a081718eb9c159
Task group: https://tools.taskcluster.net/push-inspector/#/...
Created by ...
Started by ...
--
As to ...
comment #4)
> (In reply to Mihai Tabara [:mtabara] from comment #3)
> > I think it's worth switching to push-inspector in releasewarrior too (e.g.
> > task graph from
> > https://github.com/mozilla/releasewarrior/blob/master/releases/firefox-beta-
> > 49.0b7.md)
>
> Good idea, but the PR link is 404! :P
Fair enough :) I'll redirect to the source of truth then:
https://github.com/mozilla/releasewarrior/blob/master/templates/firefox_beta.md.tmpl
https://github.com/mozilla/releasewarrior/blob/master/templates/firefox_esr.md.tmpl
https://github.com/mozilla/releasewarrior/blob/master/templates/firefox_release-rc.md.tmpl
https://github.com/mozilla/releasewarrior/blob/master/templates/firefox_release.md.tmpl
Reporter | ||
Comment 8•8 years ago
|
||
Thanks!
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8787645 -
Flags: review?(jlund)
Reporter | ||
Comment 10•8 years ago
|
||
Comment on attachment 8787645 [details] [review]
Changes task-graph-inspector link to push-inspector in releasewarrior
r+ed in the PR, merged
Attachment #8787645 -
Flags: review?(jlund)
Attachment #8787645 -
Flags: review+
Attachment #8787645 -
Flags: checked-in+
Reporter | ||
Comment 11•8 years ago
|
||
Thanks, Connor!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•