Closed Bug 1297866 Opened 8 years ago Closed 8 years ago

stylo: Assert that the tree is free of dirty bits after ProcessPendingRestyles

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bholley, Assigned: bholley)

References

Details

This is an important invariant, mostly in terms if the HAS_DIRTY_DESCENDANTS bit. The code that propagates the bit assumes that it always extends transitively up the ancestor chain. So we should assert after style context fixup that there are no stray HAS_DIRTY_DESCENDANTS bits floating around the DOM (we may need special handling for deliberately-unstyled undisplayed subtrees). We don't get this perfectly right at present, so I'm punting it to this followup bug.
Priority: -- → P2
We do this now: http://searchfox.org/mozilla-central/rev/594937fec2e2fc45fa9308ba2fb964816631f017/layout/base/ServoRestyleManager.cpp#336
Assignee: nobody → bobbyholley
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.