Closed Bug 1298112 Opened 6 years ago Closed 6 years ago

SkFontHost_cairo.cpp:763:15: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code

Categories

(Core :: Graphics, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

Details

Attachments

(1 file)

gfx/skia/skia/src/ports/SkFontHost_cairo.cpp:763:15: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
    SkASSERT(&glyph && path);
              ^~~~~ ~~
gfx/skia/skia/include/core/SkTypes.h:134:58: note: expanded from macro 'SkASSERT'
    #define SkASSERT(cond)              SkASSERT_RELEASE(cond)
                                                         ^~~~
gfx/skia/skia/include/core/SkTypes.h:131:46: note: expanded from macro 'SkASSERT_RELEASE'
#define SkASSERT_RELEASE(cond)          if(!(cond)) { SK_ABORT(#cond); }
                                             ^~~~
1 warning generated.
Attachment #8784928 - Flags: review?(gwright) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0407e91872
Remove always-true null-check to fix compile warning. r=gwright
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6f0407e91872
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.