1298112 - SkFontHost_cairo.cpp:763:15: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mats Palmgren (inactive)]

gfx/skia/skia/src/ports/SkFontHost_cairo.cpp:763:15: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
    SkASSERT(&glyph && path);
              ^~~~~ ~~
gfx/skia/skia/include/core/SkTypes.h:134:58: note: expanded from macro 'SkASSERT'
    #define SkASSERT(cond)              SkASSERT_RELEASE(cond)
                                                         ^~~~
gfx/skia/skia/include/core/SkTypes.h:131:46: note: expanded from macro 'SkASSERT_RELEASE'
#define SkASSERT_RELEASE(cond)          if(!(cond)) { SK_ABORT(#cond); }
                                             ^~~~
1 warning generated.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Remove always-true null-check to fix compile warning.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0407e91872
Remove always-true null-check to fix compile warning. r=gwright

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f0407e91872