1298144 - fix clang-cl -Wreorder warnings in WindowsGamepad.cpp

Status: RESOLVED DUPLICATE of bug 1406380

(Core :: DOM: Core & HTML, defect, P3)

Description

[Nathan Froyd [:froydnj]]

clang-cl complains thusly:

11:00.42 c:/m-c/dom/gamepad/windows/WindowsGamepad.cpp(143,5):  warning: field 'hasDpad' will be initialized after field 'type' [-Wreorder]
11:00.42     hasDpad(aHasDpad),
11:00.42     ^
11:00.42 c:/m-c/dom/gamepad/windows/WindowsGamepad.cpp(161,20):  warning: field 'mXInputEnable' will be initialized after field 'mXInputGetState' [-Wreorder]
11:00.42                    mXInputEnable(nullptr),
11:00.42                    ^
11:00.42 c:/m-c/dom/gamepad/windows/WindowsGamepad.cpp(282,17):  warning: field 'mModule' will be initialized after field 'mHidD_GetProductString' [-Wreorder]
11:00.42   HIDLoader() : mModule(LoadLibraryW(L"hid.dll")),
11:00.42                 ^

Comment 1

[Hsin-Yi Tsai (she/her) away [:hsinyi]]

Hi Nathan, I guess this is something we want to fix in the next months/release (P2); how does this sound to you?

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Hi Nathan, I guess this is something we want to fix in the next
> months/release (P2); how does this sound to you?

That would be fine, thank you!

Comment 3

[Chris Peterson [:cpeterson]]

These clang-cl warnings were fixed by MinGW bug 1406380.