1298189 - Logging broken in media/webrtc/signaling/test

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Michael Froman [:mjf]]

None of the test executables under media/webrtc/signaling/test are logging due to this: https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/test/FakeLogging.h#12

Comment 1

[Michael Froman [:mjf]]

Looks like this should fix it:
diff --git a/media/webrtc/signaling/test/FakeLogging.h b/media/webrtc/signaling/test/FakeLogging.h
--- a/media/webrtc/signaling/test/FakeLogging.h
+++ b/media/webrtc/signaling/test/FakeLogging.h
@@ -4,13 +4,23 @@

 #ifndef FakeLogging_h
 #define FakeLogging_h

 namespace mozilla {
 namespace detail {
 void log_print(const PRLogModuleInfo* aModule,
                       LogLevel aLevel,
-                      const char* aFmt, ...) { }
+                      const char* aFmt, ...)
+  {
+    // copied from Logging.cpp:#48-53
+    va_list ap;
+    va_start(ap, aFmt);
+    char* buff = PR_vsmprintf(aFmt, ap);
+    PR_LogPrint("%s", buff);
+    PR_smprintf_free(buff);
+    va_end(ap);
+  }
+
 }
 }

 #endif

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1298189 - implement logging in FakeLogging.h so we get logs when running tests.

Review commit: https://reviewboard.mozilla.org/r/74434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74434/

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8785126 [details]
Bug 1298189 - implement logging in FakeLogging.h so we get logs when running tests.

https://reviewboard.mozilla.org/r/74434/#review72536

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad5a1276f73
implement logging in FakeLogging.h so we get logs when running tests. r=drno

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ad5a1276f73