1298205 - Build failures due to missing includes in RestyleManagerBase.h and ServoRestyleManager.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

I added a file to layout/base/ which reshuffled the unified build grouping and caused build failures due to missing #includes / forward declarations.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1298205 - Fix includes of RestyleManagerBase.h.

Review commit: https://reviewboard.mozilla.org/r/74342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74342/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1298205 - Fix ServoRestyleManager.cpp includes.

Review commit: https://reviewboard.mozilla.org/r/74344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74344/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8785038 [details]
Bug 1298205 - Fix includes of RestyleManagerBase.h.

https://reviewboard.mozilla.org/r/74342/#review72252

::: layout/base/RestyleManagerBase.h:16
(Diff revision 1)
>  #include "nsChangeHint.h"
> +#include "nsPresContext.h"
> +
> +class nsCString;
> +class nsCSSFrameConstructor;
>  

Nit: drop this blank line.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8785039 [details]
Bug 1298205 - Fix ServoRestyleManager.cpp includes.

https://reviewboard.mozilla.org/r/74344/#review72254

::: layout/base/ServoRestyleManager.cpp:13
(Diff revision 1)
>  #include "mozilla/ServoStyleSet.h"
>  #include "mozilla/dom/ChildIterator.h"
>  #include "nsContentUtils.h"
>  #include "nsStyleChangeList.h"
>  
> +#include "nsPrintfCString.h"

Nit: put this before nsStyleChangeList to keep the includes (mostly) sorted.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27dc00472404
Fix includes of RestyleManagerBase.h. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/e85cd0f24510
Fix ServoRestyleManager.cpp includes. r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/27dc00472404
https://hg.mozilla.org/mozilla-central/rev/e85cd0f24510