Intermittent dom/media/test/test_webvtt_empty_displaystate.html | Cue's displayState shouldn't be empty.

RESOLVED INCOMPLETE

Status

()

Core
Audio/Video: Playback
P5
normal
RESOLVED INCOMPLETE
a year ago
25 days ago

People

(Reporter: Treeherder Bug Filer, Assigned: bechen)

Tracking

({intermittent-failure})

unspecified
mozilla55
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox-esr52 affected, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

a year ago
treeherder
Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=34734894&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1472181618/mozilla-inbound_yosemite_r7_test-mochitest-media-e10s-bm136-tests1-macosx-build230.txt.gz
Priority: -- → P5
Component: Audio/Video → Audio/Video: Playback

Comment 1

a year ago
8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-aurora: 2
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 3
* windowsxp: 2
* windows7-32: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-09-05&endday=2016-09-11&tree=all

Comment 2

a year ago
6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 3
* mozilla-inbound: 2
* mozilla-aurora: 1

Platform breakdown:
* windows7-32: 3
* linux64: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-10-24&endday=2016-10-30&tree=all

Comment 3

a year ago
6 failures in 715 pushes (0.008 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-aurora: 3
* try: 2
* autoland: 1

Platform breakdown:
* windows7-32: 4
* windows8-64: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-11-14&endday=2016-11-20&tree=all

Comment 4

a year ago
26 failures in 623 pushes (0.042 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 10
* autoland: 8
* mozilla-central: 3
* mozilla-aurora: 3
* mozilla-beta: 2

Platform breakdown:
* windows8-64: 14
* windows7-32: 10
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-11-21&endday=2016-11-27&tree=all

Comment 5

a year ago
14 failures in 694 pushes (0.02 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 5
* mozilla-inbound: 3
* mozilla-central: 2
* mozilla-beta: 2
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 9
* windows7-32: 3
* osx-10-10: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-11-28&endday=2016-12-04&tree=all

Comment 6

a year ago
7 failures in 289 pushes (0.024 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 2
* try: 1
* autoland: 1

Platform breakdown:
* windows8-64: 6
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-12-05&endday=2016-12-11&tree=all

Comment 7

a year ago
7 failures in 526 pushes (0.013 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 2
* graphics: 2
* autoland: 2
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 6
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-12-12&endday=2016-12-18&tree=all

Comment 8

a year ago
8 failures in 609 pushes (0.013 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-central: 3
* mozilla-aurora: 3
* mozilla-inbound: 1
* mozilla-beta: 1

Platform breakdown:
* windows8-64: 6
* windows7-32: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-12-19&endday=2016-12-25&tree=all

Comment 9

a year ago
9 failures in 305 pushes (0.03 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 6
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2016-12-26&endday=2017-01-01&tree=all

Comment 10

11 months ago
11 failures in 563 pushes (0.02 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 6
* mozilla-inbound: 2
* mozilla-central: 1
* mozilla-beta: 1
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 9
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-01-02&endday=2017-01-08&tree=all

Comment 11

11 months ago
15 failures in 722 pushes (0.021 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 7
* mozilla-inbound: 5
* mozilla-aurora: 3

Platform breakdown:
* windows8-64: 11
* windows7-32: 2
* osx-10-10: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-01-09&endday=2017-01-15&tree=all

Comment 12

11 months ago
15 failures in 690 pushes (0.022 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 11
* mozilla-inbound: 4

Platform breakdown:
* windows8-64: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-01-16&endday=2017-01-22&tree=all

Comment 13

11 months ago
6 failures in 749 pushes (0.008 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 1
* mozilla-beta: 1
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 5
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-01-23&endday=2017-01-29&tree=all

Comment 14

10 months ago
5 failures in 812 pushes (0.006 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* try: 1
* mozilla-inbound: 1
* mozilla-beta: 1
* mozilla-aurora: 1
* autoland: 1

Platform breakdown:
* windows8-64: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-02-20&endday=2017-02-26&tree=all
(Assignee)

Updated

9 months ago
Assignee: nobody → bechen

Comment 15

8 months ago
8 failures in 817 pushes (0.01 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* graphics: 4
* mozilla-central: 2
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* windows8-64: 3
* linux64-qr: 2
* windows7-32: 1
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 16

8 months ago
8 failures in 883 pushes (0.009 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 3
* graphics: 2
* autoland: 2
* oak: 1

Platform breakdown:
* windows8-64: 6
* linux64-qr: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-04-24&endday=2017-04-30&tree=all

Comment 17

7 months ago
7 failures in 770 pushes (0.009 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* graphics: 2
* autoland: 2
* try: 1
* mozilla-inbound: 1
* mozilla-esr52: 1

Platform breakdown:
* windows8-64: 3
* linux64-qr: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-05-01&endday=2017-05-07&tree=all
(Assignee)

Comment 18

7 months ago
After discuss with :alwu offline, we find something we need to modify or investigate.
1. The testcase assume that when a cue receive an onenter event, the displayState object should exist. This assumption is wrong because there is "missing cue" whose displayState is null but still receive onenetr event. Missing cue comes from the bad performance playback, for example: if the timeupdate are 1s, 5s, 10s, once a cue whose time is 2-3s, it is a missing cue, break the testcase.

2. In the testcase, the cue whose time is 0s to 1s, if it is a missing cue, means that the timeupdate of the MediaElement doesn't have 0s. It is weird that we don't receive the timeupdate whose time is 0s.

Comment 19

7 months ago
7 failures in 879 pushes (0.008 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 5
* mozilla-esr52: 1
* graphics: 1

Platform breakdown:
* windows8-64: 5
* linux64-qr: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-05-08&endday=2017-05-14&tree=all
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 22

7 months ago
mozreview-review
Comment on attachment 8867628 [details]
Bug 1298307 - Check cue's active state first, then verify displaystate.

https://reviewboard.mozilla.org/r/139202/#review142952
Attachment #8867628 - Flags: review?(alwu) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 24

7 months ago
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 2 changes to 2 files
remote: 
remote: WebIDL file dom/webidl/VTTCue.webidl altered in changeset e3e52ed72862 without DOM peer review
remote: 
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: 
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote: 
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.d_webidl hook failed
abort: push failed on remote
Keywords: checkin-needed
(Assignee)

Comment 25

7 months ago
mozreview-review
Comment on attachment 8867628 [details]
Bug 1298307 - Check cue's active state first, then verify displaystate.

https://reviewboard.mozilla.org/r/139202/#review143742

Hi :smaug, please help to review the patch.

The testcase wants to verify the displayState of the TextTrackCue object, and the problem is that when TextTrackCue receive the onenter event, the displayState might be empty because it is a missing cue, details in comment 18. There is a boolean member |mActive| in TextTrackCue which indicate the cue is showing or not. When the mActive is true, the displayState should be true. So I modify the VTTCue.webidl.
(Note: the displayState is a div, the root of a subtree parsed in vtt.jsm)
Comment hidden (mozreview-request)
(Assignee)

Comment 27

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37d2510dd1ed

Comment 28

7 months ago
mozreview-review
Comment on attachment 8867628 [details]
Bug 1298307 - Check cue's active state first, then verify displaystate.

https://reviewboard.mozilla.org/r/139202/#review144134
Attachment #8867628 - Flags: review?(bugs) → review+

Comment 29

7 months ago
5 failures in 777 pushes (0.006 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-esr52: 2
* autoland: 2
* mozilla-inbound: 1

Platform breakdown:
* windows8-64: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-05-15&endday=2017-05-21&tree=all
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 30

7 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd0137b3448c
Check cue's active state first, then verify displaystate. r=alwu,smaug
Keywords: checkin-needed

Comment 31

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd0137b3448c
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 32

7 months ago
15 failures in 891 pushes (0.017 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 8
* mozilla-inbound: 4
* mozilla-central: 3

Platform breakdown:
* windows8-64: 12
* linux64-qr: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-05-22&endday=2017-05-28&tree=all
This isn't fixed.
Status: RESOLVED → REOPENED
status-firefox55: fixed → affected
Flags: needinfo?(bechen)
Resolution: FIXED → ---
Target Milestone: mozilla55 → ---
(Assignee)

Comment 34

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=49ee2a166bbb
(Assignee)

Comment 35

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f96069444b57
(Assignee)

Comment 36

7 months ago
I guess we hit the timing issue.
From the log, fail seems only occurs at opt build.
The nsVideoFrame be constructed after append to dom tree, not immediately. Once the main thread and decode thread run faster than "next refresh driver tick", the TextTrackManager will early return here http://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#270

I still thinking about changing the testcase or our implementation.
Flags: needinfo?(bechen)

Comment 37

6 months ago
12 failures in 820 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 5
* try: 3
* mozilla-central: 2
* mozilla-inbound: 1
* graphics: 1

Platform breakdown:
* linux64-qr: 7
* windows8-64: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-05-29&endday=2017-06-04&tree=all
(Assignee)

Comment 38

6 months ago
Created attachment 8874288 [details] [diff] [review]
bug1298307avoidnullframe.patch
Attachment #8874288 - Flags: review?(alwu)
Comment on attachment 8874288 [details] [diff] [review]
bug1298307avoidnullframe.patch

Review of attachment 8874288 [details] [diff] [review]:
-----------------------------------------------------------------

Please also modify the comment in [1] in order to capture the case of unexpected missing cue.

[1] https://goo.gl/38QBcU

::: dom/media/test/test_webvtt_empty_displaystate.html
@@ +58,5 @@
>    info("--- check the type of cue ---");
>    isnot(window.TextTrackCue, undefined, "TextTrackCue should be defined.");
>    isnot(window.VTTCue, undefined, "VTTCue should be defined.");
>  
> +  var cue = new VTTCue(1, 2, "Test cue");

Add the check to ensure the ending time is always small than the video duration, in case someday the video duration changes.
Attachment #8874288 - Flags: review?(alwu) → review+
(Assignee)

Comment 40

6 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=119254620123
(Assignee)

Comment 41

6 months ago
Created attachment 8874366 [details] [diff] [review]
bug1298307avoidnullframe.patch
Attachment #8874288 - Attachment is obsolete: true
Attachment #8874366 - Flags: review+
(Assignee)

Comment 42

6 months ago
Hi sheriff, please help to check-in attachment 8874366 [details] [diff] [review].
Keywords: checkin-needed

Comment 43

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/028a9e5e1355
Change the cue's startTime/endTime to avoid the videoframe was not created. r=alwu
Keywords: checkin-needed

Comment 44

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/028a9e5e1355
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 45

6 months ago
5 failures in 864 pushes (0.006 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 2
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64-qr: 4
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-06-05&endday=2017-06-11&tree=all
status-firefox-esr52: --- → affected

Comment 46

6 months ago
1 failures in 892 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-release: 1

Platform breakdown:
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-06-19&endday=2017-06-25&tree=all

Comment 47

4 months ago
1 failures in 888 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-07-31&endday=2017-08-06&tree=all
(Assignee)

Comment 48

4 months ago
I hit this again on my Fennec devices, and the reproduce rate is about 0.1%.
However I have some idea to increase the reproduce rate. I'll try to reproduce it at local first.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 49

4 months ago
Here is the root cause:
https://searchfox.org/mozilla-central/source/dom/html/TextTrackManager.cpp#273

We early return here because the videoFrame is not created at the beginning.

Updated

4 months ago
Flags: needinfo?(alwu)

Comment 50

4 months ago
1 failures in 908 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* android-5-0-armv8-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-08-21&endday=2017-08-27&tree=all
Since its failure rate is super low, I think it's not worth to spend time investigating it. I'll prefer to wait for a long while to see its trend (still happen or disappear).
Flags: needinfo?(alwu)

Comment 52

3 months ago
1 failures in 939 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-08-28&endday=2017-09-03&tree=all

Comment 53

3 months ago
1 failures in 1032 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-09-11&endday=2017-09-17&tree=all
https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Last Resolved: 6 months ago2 months ago
Resolution: --- → INCOMPLETE

Comment 55

a month ago
1 failures in 857 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 1

Platform breakdown:
* macosx64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-10-30&endday=2017-11-05&tree=all

Comment 56

a month ago
1 failures in 849 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-11-06&endday=2017-11-12&tree=all

Comment 57

25 days ago
1 failures in 762 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* android-5-0-armv8-api16: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298307&startday=2017-11-13&endday=2017-11-19&tree=all
You need to log in before you can comment on or make changes to this bug.