1298457 - If you are is_staff and don't have "&autoclassify" in the URL, the autoclassification panel does not show up on first page load

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

As an is_staff sheriff on Treeherder, I'm automatically opted in to the autoclassification panel by default. It looks like there's a race condition somewhere in it, though.

If I'm signed in to Treeherder with my is_staff account and then load https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=717ef7ea17e82c6fe24fed6fe89a532dcdb28a19&filter-searchStr=3ef212a2381f11d60ce1c32ffd1794d229b29add&selectedJob=4757620 the autoclassify panel does not appear at all.

If I'm signed in to my is_staff account and load the same URL but add "&autoclassify" https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=717ef7ea17e82c6fe24fed6fe89a532dcdb28a19&filter-searchStr=3ef212a2381f11d60ce1c32ffd1794d229b29add&selectedJob=4757620 the autoclassification panel show up and is selected like it should be.


I'm guessing at the point where the job is selected during page load, my is_staff permissions have yet to be processed?

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(To get the autoclassify panel to show up as an option once the bottom panel opens without the autoclassify panel showing up, you have to unselect the job, then reselect it (or, if you're in a view with more than one job visible, just select a different job.)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think we need to listen for the userChange event that gets broadcast from https://github.com/mozilla/treeherder/blob/4c8d3f69e67e5608c6241fe0bca69a78af150fe6/ui/js/directives/treeherder/persona.js#L69

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:autoclassifydoesntshow > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8785498 [details] [review]
[treeherder] KWierso:autoclassifydoesntshow > mozilla:master

Turns out we're already listening for the userchange event: https://github.com/mozilla/treeherder/blob/f7b3d2f67d218580d8d5be97d558c5e72e57360d/ui/plugins/controller.js#L68

This patch double-checks the conditions for showing the autoclassification panel every time a job is selected in the UI, which appears to solve this bug.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/399dd8fbe95a0689d78833563bc24b9dd505a3b1
Bug 1298457 - Make sure autoclassify tab is shown when it should (#1813)

* Bug 1298457 - Make sure autoclassify tab is shown when it should

If you're a sheriff (is_staff=true) and load treeherder with a selected
job in the url, the autoclasify tab doesn't show up like it should.

This patch double-checks the conditions for showing the autoclassify panel
whenever a job gets selected.