aRequireHostMatch argument to nsCookieService::CheckPrefs is unused

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdm, Assigned: sumi29, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla51
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
It should be safe to remove this argument. If `./mach build` succeeds, it's good enough to submit a patch!

Code: netwerk/cookies/nsCookieService.cpp
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
Build passes, no test failures either (I ran the full suite just as a sanity check).
(Reporter)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8785519 [details]
Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs;

https://reviewboard.mozilla.org/r/74684/#review72552
Attachment #8785519 - Flags: review?(josh) → review+
(Reporter)

Comment 4

2 years ago
Thanks for doing this! I've instructed our automation to merge the patch, so that should begin shortly.

Comment 5

2 years ago
Pushed by jmatthews@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97f0ec5c3a9a
Remove aRequireHostMatch to nsCookieService::CheckPrefs; r=jdm
(Reporter)

Updated

2 years ago
Assignee: nobody → sumi29

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/97f0ec5c3a9a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.