Closed Bug 1298512 Opened 3 years ago Closed 3 years ago

aRequireHostMatch argument to nsCookieService::CheckPrefs is unused

Categories

(Core :: Networking: Cookies, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jdm, Assigned: sumi29, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(1 file)

It should be safe to remove this argument. If `./mach build` succeeds, it's good enough to submit a patch!

Code: netwerk/cookies/nsCookieService.cpp
Build passes, no test failures either (I ran the full suite just as a sanity check).
Comment on attachment 8785519 [details]
Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs;

https://reviewboard.mozilla.org/r/74684/#review72552
Attachment #8785519 - Flags: review?(josh) → review+
Thanks for doing this! I've instructed our automation to merge the patch, so that should begin shortly.
Pushed by jmatthews@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97f0ec5c3a9a
Remove aRequireHostMatch to nsCookieService::CheckPrefs; r=jdm
Assignee: nobody → sumi29
https://hg.mozilla.org/mozilla-central/rev/97f0ec5c3a9a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.