1298512 - aRequireHostMatch argument to nsCookieService::CheckPrefs is unused

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Josh Matthews [:jdm]]

It should be safe to remove this argument. If `./mach build` succeeds, it's good enough to submit a patch!

Code: netwerk/cookies/nsCookieService.cpp

Comment 1

[Sumit Tiwari]

Attachment: Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs;

Review commit: https://reviewboard.mozilla.org/r/74684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74684/

Comment 2

[Sumit Tiwari]

Build passes, no test failures either (I ran the full suite just as a sanity check).

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 8785519 [details]
Bug 1298512 - Remove aRequireHostMatch to nsCookieService::CheckPrefs;

https://reviewboard.mozilla.org/r/74684/#review72552

Comment 4

[Josh Matthews [:jdm]]

Thanks for doing this! I've instructed our automation to merge the patch, so that should begin shortly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97f0ec5c3a9a
Remove aRequireHostMatch to nsCookieService::CheckPrefs; r=jdm

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97f0ec5c3a9a