1298515 - Intermittent dom/media/tests/mochitest/test_getUserMedia_audioCapture.html | Assertion count 50 is greater than expected range 0-0 assertions.

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=34772391&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux-debug/1472213358/mozilla-inbound_ubuntu32_vm-debug_test-mochitest-media-e10s-bm04-tests1-linux32-build461.txt.gz

Comment 1

[Andreas Pehrson [:pehrsons]]

I'm getting this all the time locally.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1298515 - Ignore ended tracks for AudioCaptureStreams.

Review commit: https://reviewboard.mozilla.org/r/76356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76356/

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8787657 [details]
Bug 1298515 - Ignore ended tracks for AudioCaptureStreams.

https://reviewboard.mozilla.org/r/76356/#review74426

::: dom/media/AudioCaptureStream.cpp:111
(Diff revision 1)
>        while (!tracks.IsEnded()) {
>          AudioSegment* inputSegment = tracks->Get<AudioSegment>();
>          StreamTime inputStart = s->GraphTimeToStreamTimeWithBlocking(aFrom);
>          StreamTime inputEnd = s->GraphTimeToStreamTimeWithBlocking(aTo);
> +        if (tracks->IsEnded() && inputSegment->GetDuration() <= inputEnd) {
> +          // If the input track ended and we consumed all it's data it may

If the input track has ended and we consumed all of its data it can be ignored.

Comment 4

[Paul Adenot (:padenot)]

Comment on attachment 8787657 [details]
Bug 1298515 - Ignore ended tracks for AudioCaptureStreams.

https://reviewboard.mozilla.org/r/76356/#review74430

::: dom/media/AudioCaptureStream.cpp:111
(Diff revision 1)
>        while (!tracks.IsEnded()) {
>          AudioSegment* inputSegment = tracks->Get<AudioSegment>();
>          StreamTime inputStart = s->GraphTimeToStreamTimeWithBlocking(aFrom);
>          StreamTime inputEnd = s->GraphTimeToStreamTimeWithBlocking(aTo);
> +        if (tracks->IsEnded() && inputSegment->GetDuration() <= inputEnd) {
> +          // If the input track ended and we consumed all it's data it may

More like:

If the input track has ended and we have consumed all of its data it can be ignored.

Comment 5

[Intermittent Failures Robot]

13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 6
* mozilla-inbound: 3
* mozilla-beta: 2
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux32: 10
* linux64: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298515&startday=2016-08-29&endday=2016-09-04&tree=all

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8787657 [details]
Bug 1298515 - Ignore ended tracks for AudioCaptureStreams.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76356/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819eb92d9a07
Ignore ended tracks for AudioCaptureStreams. r=padenot

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/819eb92d9a07