I noticed that about:support didn't work in my de Seamonkey. This was because the string brandShorterName is not defined. Bug 1223356 changed brandShortName to brandShorterName for de to avoid that the reset profile page looks bad. Firefox introduced it specifically for the developer edition to shorten then name. Currently only this one file in this localization causes problems for Seamonkey but I think we should add the variable too to avoid future problems. Affected file https://dxr.mozilla.org/l10n-central/source/de/toolkit/chrome/global/resetProfile.dtd
status-seamonkey2.44: --- → wontfix
status-seamonkey2.45: --- → affected
status-seamonkey2.46: --- → affected
status-seamonkey2.47: --- → affected
status-seamonkey2.48: --- → affected
Created attachment 8785653 [details] [diff] [review] 1298657-brandShorterName.patch
Attachment #8785653 - Flags: review?(philip.chee)
TB doesn't define it either. If you want I can provide a patch. Currently only browser code, one test and the above de file uses it.
(In reply to Frank-Rainer Grahl from comment #2) > If you want I can provide a patch. Yes, please. Thanking you in advance.
Created attachment 8785671 [details] [diff] [review] 1298657-brandShorterName-tb.patch Patch for Thunderbird. Does Earlybird gets replaced during the build process somewhere? If yes I didn't find it. Checked esr too.
I think it goes here: https://dxr.mozilla.org/comm-central/source/other-licenses/branding/thunderbird/locales/en-US/brand.properties https://dxr.mozilla.org/comm-central/source/other-licenses/branding/thunderbird/locales/en-US/brand.dtd Richard, can you confirm?
Created attachment 8785672 [details] [diff] [review] 1298657-brandShorterName-tb-V2.patch I think that's it. Missed it because it was outside the mail dir.
Summary: Define brandShorterName in Seamonkey → Define brandShorterName in Seamonkey and Thunderbird
(In reply to Jorg K (GMT+2, PTO during summer) from comment #5) > I think it goes here: > https://dxr.mozilla.org/comm-central/source/other-licenses/branding/ > thunderbird/locales/en-US/brand.properties > https://dxr.mozilla.org/comm-central/source/other-licenses/branding/ > thunderbird/locales/en-US/brand.dtd > > Richard, can you confirm? That's right. But as I know we don't really need this brandShorterName because we use our own aboutSupport files and we have now our own issues (bug 1265175). But I'm okay to add this strings for the future.
>> But I'm okay to add this strings for the future. Aside from the one l10n file I think more or less the same. Doesn't cost much and is an insurance for future changes in the m-c tree.
Comment on attachment 8785672 [details] [diff] [review] 1298657-brandShorterName-tb-V2.patch Review of attachment 8785672 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8785672 - Flags: review?(jorgk) → review+
Hmm, I could have used that "brandShorterName" for bug 1297546, but in retrospect like the short "Default Developer Tools" label in the DevTools preferences better anyway. :-)
Comment on attachment 8785653 [details] [diff] [review] 1298657-brandShorterName.patch r=me a=me for checkin
Attachment #8785653 - Flags: review?(philip.chee) → review+
https://hg.mozilla.org/comm-central/rev/b3bb201c2710 https://hg.mozilla.org/comm-central/rev/c851b7a180b2 Opted for DONTBUILD for TB because its purely optional there. The next build can pick it up.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(In reply to Frank-Rainer Grahl from comment #12) > Opted for DONTBUILD for TB because its purely optional there. The next build > can pick it up. Indeed, no need to spend server resources on this. Although there is the argument that we should be building a few times daily to see bustage early. As they say in Australia: It's a toss up ;-)
Actually, the "DONTBUILD" didn't work. You need to apply this to the last/topmost changeset in the push.
The wonders of the build process... Thanks for letting me know. I will keep it in mind the next time and push separately if needed.
You need to log in before you can comment on or make changes to this bug.