1298657 - Define brandShorterName in Seamonkey and Thunderbird

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

I noticed that about:support didn't work in my de Seamonkey. This was because the string brandShorterName is not defined. Bug 1223356 changed brandShortName to brandShorterName for de to avoid that the reset profile page looks bad. Firefox introduced it specifically for the developer edition to shorten then name. 
Currently only this one file in this localization causes problems for Seamonkey but I think we should add the variable too to avoid future problems.

Affected file
https://dxr.mozilla.org/l10n-central/source/de/toolkit/chrome/global/resetProfile.dtd

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1298657-brandShorterName.patch

Comment 2

[Frank-Rainer Grahl (:frg)]

TB doesn't define it either. If you want I can provide a patch. Currently only browser code, one test and the above de file uses it.

Comment 3

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl from comment #2)
> If you want I can provide a patch.
Yes, please. Thanking you in advance.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1298657-brandShorterName-tb.patch

Patch for Thunderbird.

Does Earlybird gets replaced during the build process somewhere? If yes I didn't find it. Checked esr too.

Comment 5

[Jorg K (CEST = GMT+2)]

I think it goes here:
https://dxr.mozilla.org/comm-central/source/other-licenses/branding/thunderbird/locales/en-US/brand.properties
https://dxr.mozilla.org/comm-central/source/other-licenses/branding/thunderbird/locales/en-US/brand.dtd

Richard, can you confirm?

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1298657-brandShorterName-tb-V2.patch

I think that's it. Missed it because it was outside the mail dir.

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2, PTO during summer) from comment #5)
> I think it goes here:
> https://dxr.mozilla.org/comm-central/source/other-licenses/branding/
> thunderbird/locales/en-US/brand.properties
> https://dxr.mozilla.org/comm-central/source/other-licenses/branding/
> thunderbird/locales/en-US/brand.dtd
> 
> Richard, can you confirm?

That's right. But as I know we don't really need this brandShorterName because we use our own aboutSupport files and we have now our own issues (bug 1265175).

But I'm okay to add this strings for the future.

Comment 8

[Frank-Rainer Grahl (:frg)]

>> But I'm okay to add this strings for the future.

Aside from the one l10n file I think more or less the same. Doesn't cost much and is an insurance for future changes in the m-c tree.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8785672 [details] [diff] [review]
1298657-brandShorterName-tb-V2.patch

Review of attachment 8785672 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[rsx11m]

Hmm, I could have used that "brandShorterName" for bug 1297546, but in retrospect like the short "Default Developer Tools" label in the DevTools preferences better anyway. :-)

Comment 11

[Philip Chee]

Comment on attachment 8785653 [details] [diff] [review]
1298657-brandShorterName.patch

r=me a=me for checkin

Comment 12

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/b3bb201c2710
https://hg.mozilla.org/comm-central/rev/c851b7a180b2

Opted for DONTBUILD for TB because its purely optional there. The next build can pick it up.

Comment 13

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl from comment #12)
> Opted for DONTBUILD for TB because its purely optional there. The next build
> can pick it up.
Indeed, no need to spend server resources on this. Although there is the argument that we should be building a few times daily to see bustage early. As they say in Australia: It's a toss up ;-)

Comment 14

[Jorg K (CEST = GMT+2)]

Actually, the "DONTBUILD" didn't work. You need to apply this to the last/topmost changeset in the push.

Comment 15

[Frank-Rainer Grahl (:frg)]

The wonders of the build process... Thanks for letting me know. I will keep it in mind the next time and push separately if needed.