Closed
Bug 1298701
Opened 8 years ago
Closed 8 years ago
Fix a mistake in crash report annotation patch
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1372298])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1295934 +++
Coverity says "Missing comma in a string array initialization (MISSING_COMMA)"
https://hg.mozilla.org/mozilla-central/rev/813bce8554d1#l1.19
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sledru
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure
https://reviewboard.mozilla.org/r/74798/#review72632
Thanks for catching! My first reaction was "how could the compiler allow that?" and then I realized "Oh, C strings..."
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure
https://reviewboard.mozilla.org/r/74798/#review72634
Attachment #8785715 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Coverity found it. We will see if we can introduce a static analyzer check for this.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29179e545070
Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure r=njn
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•