Closed Bug 1298701 Opened 3 years ago Closed 3 years ago

Fix a mistake in crash report annotation patch

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1372298])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1295934 +++
Coverity says "Missing comma in a string array initialization (MISSING_COMMA)"

https://hg.mozilla.org/mozilla-central/rev/813bce8554d1#l1.19
Blocks: 1295934
Assignee: nobody → sledru
Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure

https://reviewboard.mozilla.org/r/74798/#review72632

Thanks for catching! My first reaction was "how could the compiler allow that?" and then I realized "Oh, C strings..."
Comment on attachment 8785715 [details]
Bug 1298701 - Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure

https://reviewboard.mozilla.org/r/74798/#review72634
Attachment #8785715 - Flags: review?(n.nethercote) → review+
Coverity found it. We will see if we can introduce a static analyzer check for this.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29179e545070
Separate the two strings (StartupCrash & TelemetryEnvironment) in the kCrashEventAnnotations structure r=njn
https://hg.mozilla.org/mozilla-central/rev/29179e545070
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.