Closed
Bug 1298723
Opened 9 years ago
Closed 9 years ago
Remove unnecessary null check in ShouldClearPurple
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 748767])
Attachments
(1 file)
|
891 bytes,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
ShouldClearPurple() checks if |aContent| is null and then dereferences it anyway (via the call to GetJSObjectChild()). Turns out the null check isn't needed because all call sites ensure the argument isn't null.
|
Assignee | |
Comment 1•9 years ago
|
||
I considered using mozilla::NotNull here but decided it was overkill.
Attachment #8785754 -
Flags: review?(continuation)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Blocks: coverity-analysis
Component: DOM → XPCOM
|
|
||
Updated•9 years ago
|
Component: XPCOM → DOM
|
|
||
Updated•9 years ago
|
Attachment #8785754 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c955143cc7bbbc29c1815590d47292189968cc0
Bug 1298723 - Remove an unnecessary null check in ShouldClearPurple. r=mccr8.
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b938bb0e73af
followup, make it actually compile, on a CLOSED TREE
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c955143cc7b
https://hg.mozilla.org/mozilla-central/rev/b938bb0e73af
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•