Closed Bug 1298723 Opened 3 years ago Closed 3 years ago
Remove unnecessary null check in Should
ShouldClearPurple() checks if |aContent| is null and then dereferences it anyway (via the call to GetJSObjectChild()). Turns out the null check isn't needed because all call sites ensure the argument isn't null.
I considered using mozilla::NotNull here but decided it was overkill.
Attachment #8785754 - Flags: review?(continuation)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Component: DOM → XPCOM
Attachment #8785754 - Flags: review?(continuation) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c955143cc7bbbc29c1815590d47292189968cc0 Bug 1298723 - Remove an unnecessary null check in ShouldClearPurple. r=mccr8.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b938bb0e73af followup, make it actually compile, on a CLOSED TREE
You need to log in before you can comment on or make changes to this bug.