Closed
Bug 1298775
Opened 8 years ago
Closed 8 years ago
support mozilla::StyleSheetHandle::RefPtr in the gdb pretty printers
Categories
(Core :: DOM: CSS Object Model, defect)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: wcpan, Assigned: wcpan)
Details
Attachments
(1 file)
I found these pointers are not easy to dereference in gdb.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
Hi Wei-Cheng, assign this to you since you've been working on this. Thanks!
Assignee: nobody → wpan
Updated•8 years ago
|
Attachment #8785917 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f64c40aedc48
Support mozilla::StyleSheetHandle::RefPtr in gdb pretty printer. r=tbsaunde
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
Comment on attachment 8785917 [details]
Bug 1298775 - Fix nullptr dereferencing.
That condition is rather long, I'd think a temporary variable would help, but please at least wrap the line.
Attachment #8785917 -
Flags: review?(tbsaunde+mozbugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•8 years ago
|
||
Extract the function to make it clearer.
I'm assuming we are not supporting Python3 yet. (reduce is not builtin in Python3)
Comment 9•8 years ago
|
||
(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #8)
> Extract the function to make it clearer.
that's cute perhaps, but I don't think its clearer than the obvious series of ifs.
> I'm assuming we are not supporting Python3 yet. (reduce is not builtin in
> Python3)
we really should support python 3, at least debian ships gdb that uses it.
Updated•8 years ago
|
Attachment #8785917 -
Flags: review?(tbsaunde+mozbugs) → review-
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8785917 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 11•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/074f9de56ac0
Fix nullptr dereferencing. r=tbsaunde
Keywords: checkin-needed
Comment 12•8 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•