Closed Bug 1298775 Opened 5 years ago Closed 5 years ago
Sheet Handle::Ref Ptr in the gdb pretty printers
I found these pointers are not easy to dereference in gdb.
Hi Wei-Cheng, assign this to you since you've been working on this. Thanks!
Assignee: nobody → wpan
5 years ago
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f64c40aedc48 Support mozilla::StyleSheetHandle::RefPtr in gdb pretty printer. r=tbsaunde
Comment on attachment 8785917 [details] Bug 1298775 - Fix nullptr dereferencing. That condition is rather long, I'd think a temporary variable would help, but please at least wrap the line.
Extract the function to make it clearer. I'm assuming we are not supporting Python3 yet. (reduce is not builtin in Python3)
(In reply to Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] from comment #8) > Extract the function to make it clearer. that's cute perhaps, but I don't think its clearer than the obvious series of ifs. > I'm assuming we are not supporting Python3 yet. (reduce is not builtin in > Python3) we really should support python 3, at least debian ships gdb that uses it.
Attachment #8785917 - Flags: review?(tbsaunde+mozbugs) → review-
5 years ago
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/074f9de56ac0 Fix nullptr dereferencing. r=tbsaunde
You need to log in before you can comment on or make changes to this bug.