1298883 - unhide security.enterprise_roots.enabled preference

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Chris]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160823121617

Steps to reproduce:

Typed about:config in the address bar, hit enter.  Searched for security.enterprise_roots.enabled.


Actual results:

security.enterprise_roots.enabled preference did not show in the about:config list.  It is currently a hidden preference.


Expected results:

security.enterprise_roots.enabled should have showed up in the list.

Comment 1

[Dana Keeler (she/her) [:keeler]]

This was done intentionally to signal that we're still developing the feature. When we've ironed more of the issues out we can add it as an unhidden pref (and maybe even something in about:preferences).

Comment 2

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1298883 - make security.enterprise_roots.enabled appear in about:config

This pref controls whether or not the platform looks for and trusts enterprise
roots (currently only available on Windows). Adding it to security-prefs.js will
make it appear in about:config, which is a much more straightforward user
experience (previously users would have to add it manually). It is still
disabled by default.

Review commit: https://reviewboard.mozilla.org/r/93278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93278/

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8811037 [details]
bug 1298883 - make security.enterprise_roots.enabled appear in about:config

https://reviewboard.mozilla.org/r/93278/#review93274

Comment 4

[Dana Keeler (she/her) [:keeler]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b4c107f00d2
make security.enterprise_roots.enabled appear in about:config r=jcj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b4c107f00d2

Comment 7

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8811037 [details]
bug 1298883 - make security.enterprise_roots.enabled appear in about:config

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: This is an enterprise-facing feature, so it would be best to make it available in this way in the next ESR (52).
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this just unhides a pref - there's very little risk to that
[String changes made/needed]: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8811037 [details]
bug 1298883 - make security.enterprise_roots.enabled appear in about:config

unhide a pref wanted for ESR, take in aurora52

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0990f3a2790f