Closed
Bug 1298974
Opened 8 years ago
Closed 8 years ago
Fix documentReady()
Categories
(L20n :: JS Library, defect)
L20n
JS Library
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
Details
(Whiteboard: [gecko-l20n])
Attachments
(1 file)
The documentReady() promise should check for the 'uninitialized' state of the XUL documents.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8786111 [details]
Bug 1298974 - Fix documentReady().
https://reviewboard.mozilla.org/r/75070/#review72950
::: toolkit/content/l20n-chrome-xul.js:362
(Diff revision 1)
>
> + getLanguages() {
> + return this.interactive.then(
> + bundles => bundles.map(bundle => bundle.map)
> + );
> + }
Inline the code if the function is to be used only once.
Attachment #8786111 -
Flags: review?(gandalf) → review+
|
Assignee | |
Comment 3•8 years ago
|
||
|
|
Assignee | |
Comment 4•8 years ago
|
||
No significant perf changes:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=c360ec477a86&newProject=try&newRevision=667a38458854&framework=1&showOnlyImportant=0
This patch increases the stability of the data overall by making sure we wait for the proper event. Landed in:
https://hg.mozilla.org/projects/larch/rev/bc60cb47882a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•