1299014 - Move clampIntToUint8 to the generic macro assembler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Move clampIntToUint8 to the generic macro assembler and mark as per shared architectures.

Comment 1

[hev [:hev]]

Attachment: 0001-Bug-1299014-Move-clampIntToUint8-to-the-generic-macr.patch

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8786175 [details] [diff] [review]
0001-Bug-1299014-Move-clampIntToUint8-to-the-generic-macr.patch

Review of attachment 8786175 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MacroAssembler.h
@@ +1602,4 @@
>          return reg.typedReg().gpr();
>      }
>  
> +    void clampIntToUint8(Register reg) PER_SHARED_ARCH;

Can we make this inline, and move all definition to -inl.h (and keep it inline on x86-shared) ?

Also, it would be nice to move this and each definition into check_macroassembler_style block to check each definition.

::: js/src/jit/x86-shared/MacroAssembler-x86-shared-inl.h
@@ -1243,5 @@
>  //}}} check_macroassembler_style
>  // ===============================================================
>  
> -void
> -MacroAssemblerX86Shared::clampIntToUint8(Register reg)

declaration in MacroAssembler-x86-shared.h should also be removed.

Comment 3

[hev [:hev]]

Attachment: 0001-Bug-1299014-Move-clampIntToUint8-to-the-generic-macr.patch

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8787059 [details] [diff] [review]
0001-Bug-1299014-Move-clampIntToUint8-to-the-generic-macr.patch

Review of attachment 8787059 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :D

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1eefd941246
Move clampIntToUint8 to the generic macro assembler. r=arai

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1eefd941246