1299055 - Update conformance2/glsl3/array-complex-indexing.html to support ANGLE/2838 update

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daosheng Mu[:daoshengmu]]

Due to ANGLE/2838 has the new syntax parser check at, https://hg.mozilla.org/try/diff/3823ac6d8833/gfx/angle/src/compiler/translator/ParseContext.cpp#l1.3772. Therefore, we need to update our array-complex-indexing.html to avoid using (a, b)[0]

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

Review commit: https://reviewboard.mozilla.org/r/75186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75186/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

https://reviewboard.mozilla.org/r/75186/#review73044

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43cb9ff43f56
Update conformance2/glsl3/array-complex-indexing.html. r=mtseng

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43cb9ff43f56

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

Approval Request Comment
This is related to ANGLE update. Because Bug 1297965 is uplift to FF 50, we need it to be uplifted as well.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

Test only changes are auto approved and do not need relman review.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Daosheng, please see my last comment.

Comment 8

[Daosheng Mu[:daoshengmu]]

(In reply to Ritu Kothari (:ritu) from comment #6)
> Comment on attachment 8786206 [details]
> Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;
> 
> Test only changes are auto approved and do not need relman review.

Ok. Thanks. Please help me uplift it to FF50.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c111cdd3063

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out from Aurora because it depends on bug 1297924, which had to be backed out.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c332306c030

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e0eb6fb60d9