If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update conformance2/glsl3/array-complex-indexing.html to support ANGLE/2838 update

RESOLVED FIXED in Firefox 50

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Tracking

unspecified
mozilla51
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Due to ANGLE/2838 has the new syntax parser check at, https://hg.mozilla.org/try/diff/3823ac6d8833/gfx/angle/src/compiler/translator/ParseContext.cpp#l1.3772. Therefore, we need to update our array-complex-indexing.html to avoid using (a, b)[0]
(Assignee)

Updated

a year ago
Blocks: 1297924
(Assignee)

Updated

a year ago
Assignee: nobody → dmu
No longer blocks: 1297924
(Assignee)

Updated

a year ago
Blocks: 1297924
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

https://reviewboard.mozilla.org/r/75186/#review73044
Attachment #8786206 - Flags: review?(mtseng) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 3

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43cb9ff43f56
Update conformance2/glsl3/array-complex-indexing.html. r=mtseng
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/43cb9ff43f56
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 5

a year ago
Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

Approval Request Comment
This is related to ANGLE update. Because Bug 1297965 is uplift to FF 50, we need it to be uplifted as well.
Attachment #8786206 - Flags: approval-mozilla-aurora?

Updated

a year ago
status-firefox50: --- → affected
Comment on attachment 8786206 [details]
Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;

Test only changes are auto approved and do not need relman review.
Attachment #8786206 - Flags: approval-mozilla-aurora?
Hi Daosheng, please see my last comment.
Flags: needinfo?(dmu)
(Assignee)

Comment 8

a year ago
(In reply to Ritu Kothari (:ritu) from comment #6)
> Comment on attachment 8786206 [details]
> Bug 1299055 - Update conformance2/glsl3/array-complex-indexing.html;
> 
> Test only changes are auto approved and do not need relman review.

Ok. Thanks. Please help me uplift it to FF50.
Flags: needinfo?(dmu)

Comment 9

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c111cdd3063
status-firefox50: affected → fixed
Flags: in-testsuite+
Backed out from Aurora because it depends on bug 1297924, which had to be backed out.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c332306c030
status-firefox50: fixed → affected

Comment 11

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/8e0eb6fb60d9
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.