1299057 - Remove EXT_disjoint_timer_query test for WebGL2

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daosheng Mu[:daoshengmu]]

Due to update ANGLE to 2838, we need to enable EXT_disjoint_timer_query extension for passing test_EXT_disjoint_timer_query.html in WebGL2.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

Review commit: https://reviewboard.mozilla.org/r/75584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75584/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

https://reviewboard.mozilla.org/r/75584/#review73518

EXT_disjoint_timer_query should be core feature in webgl2. So this looks good to me. Also ask reviewing to jgilbert for double confirm.

Comment 3

[Daosheng Mu[:daoshengmu]]

disjoint_timer_query has already become the core feature in WebGL 2. So we shouldn't use GetExtension() to use it. I think this test case is not correct originally. Just because our try servers are using old driver, they are in the blacklist and didn't run it before. (WEBGL_NATIVE_GL_OLD_NVIDIA)

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

https://reviewboard.mozilla.org/r/75584/#review73670

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a05befbd1d5c
Remove EXT_disjoint_timer_query test for WebGL 2. r=mtseng

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a05befbd1d5c

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

Approval Request Comment
This is related to ANGLE update. Because Bug 1297965 is uplift to FF 50, we need it to be uplifted as well.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

Test only changes are auto-approved and do not need relman review.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7564ca26020e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out from Aurora because it depends on bug 1297924, which had to be backed out.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c332306c030

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f6fde2a7f7a