Closed Bug 1299057 Opened 7 years ago Closed 7 years ago

Remove EXT_disjoint_timer_query test for WebGL2

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(1 file)

Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng
58 bytes, text/x-review-board-request
mtseng
: review+
jgilbert
: review+
Details 
Due to update ANGLE to 2838, we need to enable EXT_disjoint_timer_query extension for passing test_EXT_disjoint_timer_query.html in WebGL2.
Blocks: 1297924
Assignee: nobody → dmu
Summary: Enable EXT_disjoint_timer_query in WebGL2 while WebGLDraftExtensions is enabled → Remove EXT_disjoint_timer_query test for WebGL2
Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

https://reviewboard.mozilla.org/r/75584/#review73518

EXT_disjoint_timer_query should be core feature in webgl2. So this looks good to me. Also ask reviewing to jgilbert for double confirm.
Attachment #8786642 - Flags: review+
Blocks: 1297965
No longer blocks: 1297924
disjoint_timer_query has already become the core feature in WebGL 2. So we shouldn't use GetExtension() to use it. I think this test case is not correct originally. Just because our try servers are using old driver, they are in the blacklist and didn't run it before. (WEBGL_NATIVE_GL_OLD_NVIDIA)
Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

https://reviewboard.mozilla.org/r/75584/#review73670
Attachment #8786642 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a05befbd1d5c
Remove EXT_disjoint_timer_query test for WebGL 2. r=mtseng
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a05befbd1d5c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

Approval Request Comment
This is related to ANGLE update. Because Bug 1297965 is uplift to FF 50, we need it to be uplifted as well.
Attachment #8786642 - Flags: approval-mozilla-aurora?
Comment on attachment 8786642 [details]
Bug 1299057 - Remove EXT_disjoint_timer_query test for WebGL 2; ?mtseng

Test only changes are auto-approved and do not need relman review.
Attachment #8786642 - Flags: approval-mozilla-aurora?
Backed out from Aurora because it depends on bug 1297924, which had to be backed out.

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c332306c030
status-firefox50: fixed → affected
You need to log in before you can comment on or make changes to this bug.