Closed Bug 1299078 Opened 4 years ago Closed 4 years ago
Nightlies not being generated
There are currently no nightlies. Basically due to a sequence of events, our nightlies have failed to run. Event #1: http://hg.mozilla.org/build/buildbot-configs/rev/3bcc86136b6b was pushed Event #2: master had a hiccup that required restart After 'fixing' some db items, the scheduler came and went and still didn't run the builds. So.. once again, thanks to nthomas' hint, I came across the following code: http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc.py#l1979 which is : http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l252 lastGoodRev() from http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l269 returns None because there hasn't been a good Nightly build in 24hrs. So it continues to: http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l288 which checks if l10nBranch. since enable_l10n has been disabled, this is false. Therefore, lastGoodFunc() returns None. So, my current idea is to actually remove lines #292 and 293 so that it goes to line #297. 288 if not triggerBuildIfNoChanges: 289 if l10nBranch: 290 if (start-lastL10nChange) > (24*3600): 291 return None 292 else: 293 return None 294 295 # Couldn't find a good revision. Fall back to using the latest 296 # revision on this branch 297 c = lastChange(db, t, branch) 298 if c: 299 rev = c.revision 300 log.msg("lastChange returned %s" % (rev)) and looking through the ssFunc, I realized that given "triggerBuildIfNoChanges=False", the system goes to
*n-i myself to remind me to ask Callek for review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
over irc, :nthomas also suggested we use lastRevFunc instead of lastGoodFunc. at least it will avoid this problem.
was looking at production branch and thought we had lastRevFunc. We don't, so adding to misc.py
Attachment #8786259 - Attachment is obsolete: true
Summary: Nightlies scheduling failing. → Nightlies not being generated
didn't finish comment #0 apparently :( "...the system goes to http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l292 since l10nBranch is false. so it returns None.
this patch actually unhorks the nightly. but it's still a wip.
tl;dr the most recent patch forces the nightly to run. however, it still needs some fixes as within the not forceBuildLastChange condition, it has: later_rev = getLatestRev(db, t, branch, rev, last_built_revs) I just set it to an arbitrary value (i.e. the 1st item in the list). I took the lastRevFunc() and getLastBuiltRevisions() from moco's buildbotcustom code; but adapted it to our code. Though all in all, I'm still unhappy that it's just a hack to get things going. I'm wondering if we should just use the lastChange revision and build against that for the nightly?
https://hg.mozilla.org/build/buildbotcustom/rev/ac4f92670349e34455ac9ee6fcdf7b795c2505e7 Bug 1299078 - Use lastRevFunc instead of lastGoodFunc.
Will go for a post-land-review and will push fixes after. Currently the manually-applied-patches-to-fix-misc-builds needs to be applied properly.
(In reply to Edmund Wong (:ewong) from comment #9) > https://hg.mozilla.org/build/buildbotcustom/rev/ > ac4f92670349e34455ac9ee6fcdf7b795c2505e7 > Bug 1299078 - Use lastRevFunc instead of lastGoodFunc. backing this out.
https://hg.mozilla.org/build/buildbotcustom/rev/1b07611cd6c4b7d7c7d4ac395fc22e3dd895209b Bug 1299078 - Use lastRevFunc instead of lastGoodFunc.
Attachment #8798292 - Attachment description: [buildbotcustom] proposed patch (v4) → [buildbotcustom] proposed patch (v4) [checked-in]
Comment on attachment 8798292 [details] [diff] [review] [buildbotcustom] proposed patch (v4) [checked-in] considered fixed.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.