Closed
Bug 1299078
Opened 7 years ago
Closed 7 years ago
Nightlies not being generated
Categories
(SeaMonkey :: Release Engineering, defect)
SeaMonkey
Release Engineering
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file, 5 obsolete files)
5.41 KB,
patch
|
Details | Diff | Splinter Review |
There are currently no nightlies. Basically due to a sequence of events, our nightlies have failed to run. Event #1: http://hg.mozilla.org/build/buildbot-configs/rev/3bcc86136b6b was pushed Event #2: master had a hiccup that required restart After 'fixing' some db items, the scheduler came and went and still didn't run the builds. So.. once again, thanks to nthomas' hint, I came across the following code: http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc.py#l1979 which is : http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l252 lastGoodRev() from http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l269 returns None because there hasn't been a good Nightly build in 24hrs. So it continues to: http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l288 which checks if l10nBranch. since enable_l10n has been disabled, this is false. Therefore, lastGoodFunc() returns None. So, my current idea is to actually remove lines #292 and 293 so that it goes to line #297. 288 if not triggerBuildIfNoChanges: 289 if l10nBranch: 290 if (start-lastL10nChange) > (24*3600): 291 return None 292 else: 293 return None 294 295 # Couldn't find a good revision. Fall back to using the latest 296 # revision on this branch 297 c = lastChange(db, t, branch) 298 if c: 299 rev = c.revision 300 log.msg("lastChange returned %s" % (rev)) and looking through the ssFunc, I realized that given "triggerBuildIfNoChanges=False", the system goes to
![]() |
Assignee | |
Comment 1•7 years ago
|
||
*n-i myself to remind me to ask Callek for review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Flags: needinfo?(ewong)
![]() |
Assignee | |
Comment 2•7 years ago
|
||
over irc, :nthomas also suggested we use lastRevFunc instead of lastGoodFunc. at least it will avoid this problem.
![]() |
Assignee | |
Comment 3•7 years ago
|
||
![]() |
Assignee | |
Comment 4•7 years ago
|
||
was looking at production branch and thought we had lastRevFunc. We don't, so adding to misc.py
Attachment #8786259 -
Attachment is obsolete: true
Flags: needinfo?(ewong)
![]() |
Assignee | |
Updated•7 years ago
|
Summary: Nightlies scheduling failing. → Nightlies not being generated
![]() |
Assignee | |
Comment 5•7 years ago
|
||
didn't finish comment #0 apparently :( "...the system goes to http://hg.mozilla.org/build/buildbotcustom/file/seamonkey-production/misc_scheduler.py#l292 since l10nBranch is false. so it returns None.
![]() |
Assignee | |
Comment 6•7 years ago
|
||
this patch actually unhorks the nightly. but it's still a wip.
Attachment #8786262 -
Attachment is obsolete: true
Attachment #8786676 -
Flags: review?(bugspam.Callek)
![]() |
Assignee | |
Comment 7•7 years ago
|
||
tl;dr the most recent patch forces the nightly to run. however, it still needs some fixes as within the not forceBuildLastChange condition, it has: later_rev = getLatestRev(db, t, branch, rev, last_built_revs[0]) I just set it to an arbitrary value (i.e. the 1st item in the list). I took the lastRevFunc() and getLastBuiltRevisions() from moco's buildbotcustom code; but adapted it to our code. Though all in all, I'm still unhappy that it's just a hack to get things going. I'm wondering if we should just use the lastChange revision and build against that for the nightly?
![]() |
Assignee | |
Comment 8•7 years ago
|
||
Attachment #8786676 -
Attachment is obsolete: true
Attachment #8786676 -
Flags: review?(bugspam.Callek)
Attachment #8787085 -
Flags: feedback?(bugspam.Callek)
![]() |
Assignee | |
Comment 9•7 years ago
|
||
https://hg.mozilla.org/build/buildbotcustom/rev/ac4f92670349e34455ac9ee6fcdf7b795c2505e7 Bug 1299078 - Use lastRevFunc instead of lastGoodFunc.
![]() |
Assignee | |
Comment 10•7 years ago
|
||
Will go for a post-land-review and will push fixes after. Currently the manually-applied-patches-to-fix-misc-builds needs to be applied properly.
Attachment #8786255 -
Attachment is obsolete: true
Attachment #8787085 -
Attachment is obsolete: true
Attachment #8787085 -
Flags: feedback?(bugspam.Callek)
Attachment #8798292 -
Flags: review?(bugspam.Callek)
![]() |
Assignee | |
Comment 11•7 years ago
|
||
(In reply to Edmund Wong (:ewong) from comment #9) > https://hg.mozilla.org/build/buildbotcustom/rev/ > ac4f92670349e34455ac9ee6fcdf7b795c2505e7 > Bug 1299078 - Use lastRevFunc instead of lastGoodFunc. backing this out.
![]() |
Assignee | |
Comment 12•7 years ago
|
||
https://hg.mozilla.org/build/buildbotcustom/rev/1b07611cd6c4b7d7c7d4ac395fc22e3dd895209b Bug 1299078 - Use lastRevFunc instead of lastGoodFunc.
![]() |
Assignee | |
Updated•7 years ago
|
Attachment #8798292 -
Attachment description: [buildbotcustom] proposed patch (v4) → [buildbotcustom] proposed patch (v4) [checked-in]
![]() |
Assignee | |
Comment 13•7 years ago
|
||
Comment on attachment 8798292 [details] [diff] [review] [buildbotcustom] proposed patch (v4) [checked-in] considered fixed.
Attachment #8798292 -
Flags: review?(bugspam.Callek)
![]() |
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•