Closed Bug 1299139 Opened 5 years ago Closed 2 years ago

Don't export symbols from soundtouch on Windows

Categories

(Core :: Audio/Video: Playback, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: benjamin, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Currently we export a few soundtouch symbols from xul.dll on Windows only. Ehsan already fixed this on other platforms in bug 978856, but we don't need the windows case either here.
Blocks: 1299187
Component: Audio/Video → Audio/Video: Playback
Benjamin - who are you expecting to work on this?
Flags: needinfo?(benjamin)
It's not a high priority. You're welcome to mark it P5.

What I've found is that most of soundtouch is exported correctly from lgpllibs. There are a few functions which are inlined and then exported from xul. soundtouch doesn't have an "import" macro, just an export macro, which is ok because windows will automatically redirect imported functions through a thunk, although it will be slightly less efficient.
Flags: needinfo?(benjamin)
Assignee: benjamin → nobody
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a756ef52e84f
Don't export symbols from soundtouch on Windows; r=padenot
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.