All users were logged out of Bugzilla on October 13th, 2018

Don't export symbols from soundtouch on Windows

NEW
Unassigned

Status

()

P5
normal
2 years ago
a year ago

People

(Reporter: benjamin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
Currently we export a few soundtouch symbols from xul.dll on Windows only. Ehsan already fixed this on other platforms in bug 978856, but we don't need the windows case either here.
(Reporter)

Updated

2 years ago
Blocks: 1299187
Component: Audio/Video → Audio/Video: Playback
Benjamin - who are you expecting to work on this?
Flags: needinfo?(benjamin)
(Reporter)

Comment 2

2 years ago
It's not a high priority. You're welcome to mark it P5.

What I've found is that most of soundtouch is exported correctly from lgpllibs. There are a few functions which are inlined and then exported from xul. soundtouch doesn't have an "import" macro, just an export macro, which is ok because windows will automatically redirect imported functions through a thunk, although it will be slightly less efficient.
Flags: needinfo?(benjamin)
Priority: -- → P5
(Reporter)

Updated

a year ago
Assignee: benjamin → nobody
You need to log in before you can comment on or make changes to this bug.