1299139 - Don't export symbols from soundtouch on Windows

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Benjamin Smedberg]

Currently we export a few soundtouch symbols from xul.dll on Windows only. Ehsan already fixed this on other platforms in bug 978856, but we don't need the windows case either here.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Benjamin - who are you expecting to work on this?

Comment 2

[Benjamin Smedberg]

It's not a high priority. You're welcome to mark it P5.

What I've found is that most of soundtouch is exported correctly from lgpllibs. There are a few functions which are inlined and then exported from xul. soundtouch doesn't have an "import" macro, just an export macro, which is ok because windows will automatically redirect imported functions through a thunk, although it will be slightly less efficient.

Comment 3

[(no longer active)]

Attachment: Bug 1299139 - Don't export symbols from soundtouch on Windows;

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a756ef52e84f
Don't export symbols from soundtouch on Windows; r=padenot

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a756ef52e84f