Closed Bug 1299139 Opened 5 years ago Closed 2 years ago
Don't export symbols from soundtouch on Windows
47 bytes, text/x-phabricator-request
|Details | Review|
Currently we export a few soundtouch symbols from xul.dll on Windows only. Ehsan already fixed this on other platforms in bug 978856, but we don't need the windows case either here.
Benjamin - who are you expecting to work on this?
It's not a high priority. You're welcome to mark it P5. What I've found is that most of soundtouch is exported correctly from lgpllibs. There are a few functions which are inlined and then exported from xul. soundtouch doesn't have an "import" macro, just an export macro, which is ok because windows will automatically redirect imported functions through a thunk, although it will be slightly less efficient.
5 years ago
Priority: -- → P5
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a756ef52e84f Don't export symbols from soundtouch on Windows; r=padenot
Assignee: nobody → ehsan
You need to log in before you can comment on or make changes to this bug.