Closed Bug 1299143 Opened 5 years ago Closed 5 years ago
.snapshot .static can probably be removed
58 bytes, text/x-review-board-request
After bug 1288745 it looks as though snapshot.static (as seen in nsITelemetry.idl#65  could always be true. We should consider removing this if this is the case. (also, I'm not sure anyone uses it. A casual DXR  suggests that may be the case) : https://dxr.mozilla.org/mozilla-central/rev/26e22af660e543ebb69930f082188b69ec756185/toolkit/components/telemetry/nsITelemetry.idl#65 : https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%22%5C.static%5B%5E%5Cw%5D%22&redirect=false
Priority: -- → P3
Assignee: adamgj.wong → nobody
Status: ASSIGNED → NEW
A casual look at histogram snapshots and around TelemetryHistogram.cpp suggests that `static` is not actually in the snapshot anymore. Apparently the comment is just outdated and we should remove the mention of "static".
Whiteboard: [measurement:client] → [measurement:client] [lang=c++]
Comment on attachment 8788750 [details] Bug 1299143 - Remove outdated comment about Telemetry.snapshot.static. https://reviewboard.mozilla.org/r/77150/#review75366 This looks good, thanks1
Attachment #8788750 - Flags: review?(gfritzsche) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ab12d34f3145 Remove outdated comment about Telemetry.snapshot.static. r=gfritzsche
You need to log in before you can comment on or make changes to this bug.