Telemetry.snapshot.static can probably be removed

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: chutten, Assigned: adamg2, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

unspecified
mozilla51
good-first-bug
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [measurement:client] [lang=c++])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
After bug 1288745 it looks as though snapshot.static (as seen in nsITelemetry.idl#65 [1] could always be true. We should consider removing this if this is the case.

(also, I'm not sure anyone uses it. A casual DXR [2] suggests that may be the case)

[1]: https://dxr.mozilla.org/mozilla-central/rev/26e22af660e543ebb69930f082188b69ec756185/toolkit/components/telemetry/nsITelemetry.idl#65
[2]: https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%22%5C.static%5B%5E%5Cw%5D%22&redirect=false
Priority: -- → P3
Whiteboard: [measurement:client]
Assignee: adamgj.wong → nobody
Status: ASSIGNED → NEW
A casual look at histogram snapshots and around TelemetryHistogram.cpp suggests that `static` is not actually in the snapshot anymore.
Apparently the comment is just outdated and we should remove the mention of "static".
Mentor: gfritzsche@mozilla.com
Keywords: good-first-bug
Whiteboard: [measurement:client] → [measurement:client] [lang=c++]
Assignee: nobody → adamgj.wong
Blocks: 1201022
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8788750 [details]
Bug 1299143 - Remove outdated comment about Telemetry.snapshot.static.

https://reviewboard.mozilla.org/r/77150/#review75366

This looks good, thanks1
Attachment #8788750 - Flags: review?(gfritzsche) → review+

Comment 4

a year ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/ab12d34f3145
Remove outdated comment about Telemetry.snapshot.static. r=gfritzsche

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ab12d34f3145
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.