Closed Bug 1299143 Opened 4 years ago Closed 4 years ago

Telemetry.snapshot.static can probably be removed

Categories

(Toolkit :: Telemetry, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: chutten, Assigned: adamg2, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [measurement:client] [lang=c++])

Attachments

(1 file)

After bug 1288745 it looks as though snapshot.static (as seen in nsITelemetry.idl#65 [1] could always be true. We should consider removing this if this is the case.

(also, I'm not sure anyone uses it. A casual DXR [2] suggests that may be the case)

[1]: https://dxr.mozilla.org/mozilla-central/rev/26e22af660e543ebb69930f082188b69ec756185/toolkit/components/telemetry/nsITelemetry.idl#65
[2]: https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%22%5C.static%5B%5E%5Cw%5D%22&redirect=false
Priority: -- → P3
Whiteboard: [measurement:client]
Assignee: adamgj.wong → nobody
Status: ASSIGNED → NEW
A casual look at histogram snapshots and around TelemetryHistogram.cpp suggests that `static` is not actually in the snapshot anymore.
Apparently the comment is just outdated and we should remove the mention of "static".
Mentor: gfritzsche
Keywords: good-first-bug
Whiteboard: [measurement:client] → [measurement:client] [lang=c++]
Assignee: nobody → adamgj.wong
Comment on attachment 8788750 [details]
Bug 1299143 - Remove outdated comment about Telemetry.snapshot.static.

https://reviewboard.mozilla.org/r/77150/#review75366

This looks good, thanks1
Attachment #8788750 - Flags: review?(gfritzsche) → review+
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/ab12d34f3145
Remove outdated comment about Telemetry.snapshot.static. r=gfritzsche
https://hg.mozilla.org/mozilla-central/rev/ab12d34f3145
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.