Closed Bug 1299144 Opened 4 years ago Closed 4 years ago
Histogram::New Keyed Histogram
58 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1288745 +++ NewKeyedHistogram is only used by tests . For tests we already have the TELEMETRY_TEST_* histograms if we need histograms of particular compositions. 1) Add necessary TELEMETRY_TEST_* histograms 2) Convert tests to use TELEMETRY_TEST_* histograms instead of NewKeyedHistogram 3) Remove NewKeyedHistogram and anything else that supports only it (for instance, I think IsValidHistogramName would now no longer be used) : https://dxr.mozilla.org/mozilla-central/search?q=ewKeyedHistogram&case=true&=mozilla-central
Assignee: adamgj.wong → nobody
Status: ASSIGNED → NEW
Comment on attachment 8790153 [details] Bug 1299144 - Replace TelemetryHistogram::NewKeyedHistogram and replace with predefined histograms. https://reviewboard.mozilla.org/r/78106/#review76628 ::: toolkit/components/telemetry/nsITelemetry.idl:231 (Diff revision 1) > /** > - * Same as newKeyedHistogram above, but for histograms registered in TelemetryHistograms.h. > + * Create and return a histogram registered in TelemetryHistograms.h. > * > * @param id - unique identifier from TelemetryHistograms.h > - * The returned object has the same functions as a histogram returned from newKeyedHistogram. > + * The returned object has the following functions: > + * add(string key, [optional] int) - Add an int value to the histogram for that key. If no histogram for that key exists yet, it is created. Nice catch ::: toolkit/components/telemetry/tests/unit/test_nsITelemetry.js:629 (Diff revision 1) > h.add(TEST_KEY, 1); > Assert.equal(h.snapshot(TEST_KEY).sum, 0, > "The keyed histograms should not record any data."); > > // Runtime created histograms should not be recorded. > - h = Telemetry.newKeyedHistogram("test::runtime_keyed_boolean", "never", Telemetry.HISTOGRAM_BOOLEAN); > + h = Telemetry.getKeyedHistogramById("TELEMETRY_TEST_KEYED_BOOLEAN"); This test becomes a clone of the above "Extended set keyed histograms should not be recorded", so remove it instead.
Comment on attachment 8790153 [details] Bug 1299144 - Replace TelemetryHistogram::NewKeyedHistogram and replace with predefined histograms. https://reviewboard.mozilla.org/r/78106/#review77044
Attachment #8790153 - Flags: review?(chutten) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a38442afa931 Replace TelemetryHistogram::NewKeyedHistogram and replace with predefined histograms. r=chutten
You need to log in before you can comment on or make changes to this bug.