Closed Bug 1299154 Opened 4 years ago Closed 3 years ago
Override DPPX to doc Shell's Restore From History
58 bytes, text/x-review-board-request
In bug 1241867 we added a way to override the dppx of the contentViewer without affecting the rendering. However, we missed one place that prevent to transfer the settings from the old contentViewer to the new one. That is important for bug 1254385, since the user – once has selected a device – could also navigate the page or reload it. Also, it should be done for consistency (e.g. FullZoom)
Whiteboard: [multiviewport] [mvp-rdm] → [multiviewport] [triage]
Priority: -- → P2
Whiteboard: [multiviewport] [triage] → [multiviewport] [reserve-rdm]
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Iteration: --- → 51.3 - Sep 12
Priority: P2 → P1
Comment on attachment 8786364 [details] Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory; https://reviewboard.mozilla.org/r/75336/#review73180 looks good
Attachment #8786364 - Flags: review?(mstange) → review+
Unit test added; here the try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=703dabb2bf9d&selectedJob=26655940 The oranges doesn't seems related to this patch.
Hi Markus, as discussed I added the unit test; let me know if it's fine for you.
Yes, this looks good, thank you.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/541c9086c0f2 added Set/GetOverrideDPPX to restorefromHistory; r=mstange
You need to log in before you can comment on or make changes to this bug.