Add Set/GetOverrideDPPX to docShell's RestoreFromHistory

RESOLVED FIXED in Firefox 51

Status

P1
normal
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: zer0, Assigned: zer0)

Tracking

unspecified
Firefox 51
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [multiviewport] [reserve-rdm])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In bug 1241867 we added a way to override the dppx of the contentViewer without affecting the rendering. However, we missed one place that prevent to transfer the settings from the old contentViewer to the new one. That is important for bug 1254385, since the user – once has selected a device – could also navigate the page or reload it.

Also, it should be done for consistency (e.g. FullZoom)

Updated

2 years ago
Whiteboard: [multiviewport] [mvp-rdm] → [multiviewport] [triage]

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [multiviewport] [triage] → [multiviewport] [reserve-rdm]
(Assignee)

Updated

2 years ago
No longer blocks: 1254385
See Also: → bug 1254385
Comment hidden (mozreview-request)

Updated

2 years ago
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Iteration: --- → 51.3 - Sep 12
Priority: P2 → P1
Blocks: 758011

Comment 2

2 years ago
mozreview-review
Comment on attachment 8786364 [details]
Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory;

https://reviewboard.mozilla.org/r/75336/#review73180

looks good
Attachment #8786364 - Flags: review?(mstange) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
Unit test added; here the try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=703dabb2bf9d&selectedJob=26655940

The oranges doesn't seems related to this patch.
(Assignee)

Comment 5

2 years ago
Hi Markus, as discussed I added the unit test; let me know if it's fine for you.
Flags: needinfo?(mstange)
Yes, this looks good, thank you.
Flags: needinfo?(mstange)

Comment 7

2 years ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/541c9086c0f2
added Set/GetOverrideDPPX to restorefromHistory; r=mstange

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/541c9086c0f2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

2 years ago
Depends on: 1340592

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.