1299154 - Add Set/GetOverrideDPPX to docShell's RestoreFromHistory

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

In bug 1241867 we added a way to override the dppx of the contentViewer without affecting the rendering. However, we missed one place that prevent to transfer the settings from the old contentViewer to the new one. That is important for bug 1254385, since the user – once has selected a device – could also navigate the page or reload it.

Also, it should be done for consistency (e.g. FullZoom)

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory;

Review commit: https://reviewboard.mozilla.org/r/75336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75336/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8786364 [details]
Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory;

https://reviewboard.mozilla.org/r/75336/#review73180

looks good

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8786364 [details]
Bug 1299154 - added Set/GetOverrideDPPX to restorefromHistory;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75336/diff/1-2/

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Unit test added; here the try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=703dabb2bf9d&selectedJob=26655940

The oranges doesn't seems related to this patch.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Hi Markus, as discussed I added the unit test; let me know if it's fine for you.

Comment 6

[Markus Stange [:mstange]]

Yes, this looks good, thank you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/541c9086c0f2
added Set/GetOverrideDPPX to restorefromHistory; r=mstange

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/541c9086c0f2