1299199 - [Pointer Events] Replace all `sendPointerEvent()` with `sendMouseEvent()` in testcases.

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Ben Hsu [:HoPang]]

Now, we can directly synthesize WidgetMouseEvents, WidgetTouchEvents, and
WidgetPointerEvents in testcases. However, WidgetPointerEvents are only created after `PresShell`, so the test automation API shouldn't send WidgetPointerEvents directly. Instead, we should only send WidgetMouseEvents and WidgetTouchEvents, and let Gecko create WidgetPointerEvents itself.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Ben, if I understand your plan correctly, this is something we aim at by the end of this quarter. So, I mark it as P2, i.e. in the next release/few months. Let me know if I misunderstand the plan.

Comment 2

[Ben Hsu [:HoPang]]

Attachment: Part 1: Replace all `sendPointerEvent()` with `sendMouseEvent()` in testcases.

Comment 3

[Ben Hsu [:HoPang]]

Attachment: Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Comment 4

[Ben Hsu [:HoPang]]

Attachment: Part 1: Replace all `sendPointerEvent()` with `sendMouseEvent()` in testcases.

Comment 5

[Ben Hsu [:HoPang]]

Attachment: Part 1: Replace all `sendPointerEvent()` with `sendMouseEvent()` in testcases.

Comment 6

[Ben Hsu [:HoPang]]

The first patch replaces all `sendPointerEvent()` to `sendMouseEvent()`, but the widget event sequences are neither verified nor updated in this patch. Given the fact that Gecko generates widget pointer events itself, doing this doesn't change the behavior of any testcase.

The second patch removes `sendPointerEvent()` only in `mochitest_support_external.js`. In fact, I am thinking remove this method entirely, but IMHO we should secure the sanity of the test automation and testcases first, and file another bug to investigate whether and how to remove `sendPointerEvent()` entirely (i.e., in EventUtils.js).

Comment 7

[Ben Hsu [:HoPang]]

Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Hi Bevis, and sorry for bothering you again.

Do you mind giving feedback on these two patches?
Please refer to comment 6 for more information.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Review of attachment 8788408 [details] [diff] [review]:
-----------------------------------------------------------------

This is our 1st step to clean up the abuse of synthesizePointer in pointerevent test cases.
The next step is to clean up the use of synthesizePointer in the test framework.

Please have a followup bug for tracking this, thanks!

Comment 9

[Ben Hsu [:HoPang]]

(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #8)
> 
> Please have a followup bug for tracking this, thanks!

Thanks for reminding, bug 1302034 is filed for tracking this :)

Comment 10

[Ben Hsu [:HoPang]]

Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Hi Olli,

Do you mind reviewing these patches? The detailed description is in comment 6, and the following bug 1302034 is also fired.

Comment 11

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a869cc1c13d&selectedJob=27334627

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48d5b33726be
Part 1: Replace 'sendPointerEvent()' with 'sendMouseEvent()' in testcases. f=btseng, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4569b204d657
Part 2: Remove 'sendPointerEvent' from mochitest_support_external.js. f=btseng, r=smaug

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48d5b33726be
https://hg.mozilla.org/mozilla-central/rev/4569b204d657