Closed Bug 1299199 Opened 3 years ago Closed 3 years ago

[Pointer Events] Replace all `sendPointerEvent()` with `sendMouseEvent()` in testcases.

Categories

(Core :: DOM: Events, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bhsu, Assigned: bhsu)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Now, we can directly synthesize WidgetMouseEvents, WidgetTouchEvents, and
WidgetPointerEvents in testcases. However, WidgetPointerEvents are only created after `PresShell`, so the test automation API shouldn't send WidgetPointerEvents directly. Instead, we should only send WidgetMouseEvents and WidgetTouchEvents, and let Gecko create WidgetPointerEvents itself.
Blocks: 1299024
Hi Ben, if I understand your plan correctly, this is something we aim at by the end of this quarter. So, I mark it as P2, i.e. in the next release/few months. Let me know if I misunderstand the plan.
Priority: -- → P2
Assignee: nobody → bhsu
The first patch replaces all `sendPointerEvent()` to `sendMouseEvent()`, but the widget event sequences are neither verified nor updated in this patch. Given the fact that Gecko generates widget pointer events itself, doing this doesn't change the behavior of any testcase.

The second patch removes `sendPointerEvent()` only in `mochitest_support_external.js`. In fact, I am thinking remove this method entirely, but IMHO we should secure the sanity of the test automation and testcases first, and file another bug to investigate whether and how to remove `sendPointerEvent()` entirely (i.e., in EventUtils.js).
Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Hi Bevis, and sorry for bothering you again.

Do you mind giving feedback on these two patches?
Please refer to comment 6 for more information.
Attachment #8788408 - Flags: feedback?(btseng)
Attachment #8788734 - Flags: feedback?(btseng)
Attachment #8788734 - Flags: feedback?(btseng) → feedback+
Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Review of attachment 8788408 [details] [diff] [review]:
-----------------------------------------------------------------

This is our 1st step to clean up the abuse of synthesizePointer in pointerevent test cases.
The next step is to clean up the use of synthesizePointer in the test framework.

Please have a followup bug for tracking this, thanks!
Attachment #8788408 - Flags: feedback?(btseng) → feedback+
Blocks: 1302034
(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #8)
> 
> Please have a followup bug for tracking this, thanks!

Thanks for reminding, bug 1302034 is filed for tracking this :)
Comment on attachment 8788408 [details] [diff] [review]
Part 2: Remove `sendPointerEvent` in mochitest_support_external.js.

Hi Olli,

Do you mind reviewing these patches? The detailed description is in comment 6, and the following bug 1302034 is also fired.
Attachment #8788408 - Flags: review?(bugs)
Attachment #8788734 - Flags: review?(bugs)
Attachment #8788408 - Flags: review?(bugs) → review+
Attachment #8788734 - Flags: review?(bugs) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48d5b33726be
Part 1: Replace 'sendPointerEvent()' with 'sendMouseEvent()' in testcases. f=btseng, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4569b204d657
Part 2: Remove 'sendPointerEvent' from mochitest_support_external.js. f=btseng, r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/48d5b33726be
https://hg.mozilla.org/mozilla-central/rev/4569b204d657
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.